[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: GUILE_MAX_HEAP_SIZE
From: |
Han-Wen Nienhuys |
Subject: |
Re: GUILE_MAX_HEAP_SIZE |
Date: |
Fri, 22 Aug 2008 00:36:29 -0300 |
User-agent: |
Thunderbird 2.0.0.16 (X11/20080723) |
Han-Wen Nienhuys escreveu:
> Ludovic Courtès escreveu:
>> Hello,
>>
>> Han-Wen Nienhuys <address@hidden> writes:
>>
>>> Ludovic Courtès escreveu:
>>>> Off the top of my head: incorrect indentation, missing spaces around
>>>> brackets, and more importantly comments (see (standards.info)Comments).
>>> The code I went through should not have that; please point me to locations
>>> where things are broken so I can fix them.
>> E.g., from commit:
>>
>> +/*
>> + Classic MIT Hack, see e.g. http://www.tekpool.com/?cat=9
>> + */
>> +int scm_i_uint_bit_count(unsigned int u)
>>
>> (BTW, it'd make sense to use Gnulib's `count-one-bits' module, which is
>> able to use GCC's `__builtin_popcount ()'.)
Could you add the gnulib module? I'll do the rest.
--
Han-Wen Nienhuys - address@hidden - http://www.xs4all.nl/~hanwen
- Re: GUILE_MAX_HEAP_SIZE, (continued)
- Re: GUILE_MAX_HEAP_SIZE, Ludovic Courtès, 2008/08/17
- Re: GUILE_MAX_HEAP_SIZE, Ludovic Courtès, 2008/08/18
- Re: GUILE_MAX_HEAP_SIZE, Han-Wen Nienhuys, 2008/08/18
- Re: GUILE_MAX_HEAP_SIZE, Han-Wen Nienhuys, 2008/08/18
- Re: GUILE_MAX_HEAP_SIZE, Ludovic Courtès, 2008/08/18
- Re: GUILE_MAX_HEAP_SIZE, Han-Wen Nienhuys, 2008/08/19
- Re: GUILE_MAX_HEAP_SIZE, Ludovic Courtès, 2008/08/19
- Re: GUILE_MAX_HEAP_SIZE, Han-Wen Nienhuys, 2008/08/19
- Re: GUILE_MAX_HEAP_SIZE, Ludovic Courtès, 2008/08/21
- Re: GUILE_MAX_HEAP_SIZE, Han-Wen Nienhuys, 2008/08/21
- Re: GUILE_MAX_HEAP_SIZE,
Han-Wen Nienhuys <=
- Re: GUILE_MAX_HEAP_SIZE, Ludovic Courtès, 2008/08/22
- Re: GUILE_MAX_HEAP_SIZE, Han-Wen Nienhuys, 2008/08/21
- Re: GUILE_MAX_HEAP_SIZE, Ludovic Courtès, 2008/08/22
- Re: GUILE_MAX_HEAP_SIZE, Ludovic Courtès, 2008/08/18
- Re: GUILE_MAX_HEAP_SIZE, Han-Wen Nienhuys, 2008/08/18
- Re: GUILE_MAX_HEAP_SIZE, Ludovic Courtès, 2008/08/18
- Re: GUILE_MAX_HEAP_SIZE, Han-Wen Nienhuys, 2008/08/19
- Re: GUILE_MAX_HEAP_SIZE, Ludovic Courtès, 2008/08/18
- Re: GUILE_MAX_HEAP_SIZE, Han-Wen Nienhuys, 2008/08/19
- Re: GUILE_MAX_HEAP_SIZE, Han-Wen Nienhuys, 2008/08/19