[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/3] gnu: Add MariaDB.
From: |
宋文武 |
Subject: |
Re: [PATCH 3/3] gnu: Add MariaDB. |
Date: |
Fri, 17 Apr 2015 21:02:42 +0800 |
User-agent: |
Notmuch/0.18.1 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-unknown-linux-gnu) |
Ludovic Courtès <address@hidden> writes:
> 宋文武 <address@hidden> skribis:
>
>> * gnu/packages/database.scm (mariadb): New variable.
>
> +s: “databases.scm”
>
>> + 'configure 'pre-configure
>> + (lambda _
>> + (setenv "CONFIG_SHELL" (which "sh"))
>> + ;; XXX: libstdc++.so lacks RUNPATH for libgcc_s.so.
>> + (setenv "LDFLAGS" "-lgcc_s")
>
> Indeed, but this is normally compensated by the fact that our GCC
> automatically passed -Wl,-rpath=$gcclibdir, no? What error where you
> getting without it?
Without this flag, all binaries are broken (they linked with
libstdc++.so but with libgcc_s.so not found).
>
>> + ;; Install testing data to the 'test' output.
>> + (mkdir-p test)
>> + (system* "mv" (string-append out "/data") test)
>> + (system* "mv" (string-append out "/mysql-test") test)
>> + (system* "mv" (string-append out "/sql-bench") test)))
>
> Could you use ‘rename-file’?
It seem that those are assumed to be installed with the same
basedir as mariadb, and I failed to trick it to run.
I'd like to remove those test data (and the 'test' output).
>
> Otherwise LGTM.
>
> Thanks,
> Ludo’.