Re: [PATCHES] Add totem

[Mark H Weaver]

address@hidden (Ludovic Courtès) writes:

>> From ba786fa3d1d7896336dca3b364bb630142c30fa1 Mon Sep 17 00:00:00 2001
>> From: Mark H Weaver <address@hidden>
>> Date: Sat, 20 Jun 2015 21:09:54 -0400
>> Subject: [PATCH 2/3] gnu: Add grilo-plugins.
>>
>> * gnu/packages/gnome.scm (grilo-plugins): New variable.
>
> [...]
>
>> +     `(#:make-flags (list (string-append "GRL_PLUGINS_DIR="
>> +                                         %output
>> +                                         "/lib/grilo-"
>> +                                         ,(version-major+minor version)))
>> +       ;; XXX FIXME: Investigate test failure:
>> +       ;;   TEST: test_apple_trailers... (pid=8718)
>> +       ;;     /apple-trailers/browse/count:
>> +       ;;   ERROR:test_apple_trailers.c:88:test_browse_count: assertion 
>> failed: (source)
>> +       ;;   FAIL
>> +       #:tests? #f))
>
> Would it be OK to skip just this for now?  If that’s too much, we can
> leave it for later.

"make check" aborts after this failure, which is the first test.  I
tried "make -k check" and found that _all_ tests fail with the same
assertion failure when run in the build container.

However, if I run "make -k check" on the failed build directory in
/tmp/nix-build-* from outside of the build container, all but one of the
tests succeeds.  This when using the precise environment variable
settings from the build and no others.  Using strace, I found that it
was accessing the system dbus, so I guess that's the problem.

>> +    (synopsis "Framework for discovering and browsing media - Plugins")
>
> Maybe “Plugins for the Grilo media discovery library”?

Yes, that's better, thanks!

I'm going to hold off on pushing grilo{-plugins} and totem until the
'nettle-fix' branch is merged (it fixes gst-libav on x86_64), and also
to get more feedback on how best to handle totem's required plugins and
dbus services.

      Thanks,
        Mark