[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Add aragorn.
From: |
Ricardo Wurmus |
Subject: |
Re: [PATCH] Add aragorn. |
Date: |
Tue, 21 Jul 2015 16:42:09 +0200 |
Thompson, David <address@hidden> writes:
> On Tue, Jul 21, 2015 at 9:57 AM, Ricardo Wurmus
> <address@hidden> wrote:
>> Something’s wrong with the alignment of the ‘(replace 'install ...)’.
>> If there are no objections I can fix the alignment and push without
>> requesting another version of the patch.
>>
>> But I think I better wait for other comments.
>
> Looks fine to me, sans the alignment. One additional nitpick is the
> 'string-append' calls. The newlines should happen *after* the first
> argument, not before.
I fixed the alignment and made a couple of small modifications to
prettify the ‘string-append’ calls. Pushed as 8dc797f.
Thanks again!
~~ Ricardo