Re: Add guix install command

[Alex Kost]

Mathieu Lirzin (2015-08-07 13:08 +0300) wrote:

> Alex Kost <address@hidden> writes:
>
>> Andy Wingo (2015-08-05 12:36 +0300) wrote:
>>[...]
>>> Attached is a patch to implement "guix install".  It just copies over
>>> functionality from guix package.  We could refactor more but I would
>>> start with this as it is; when things need changes is the time to
>>> refactor, at least for me.  What do you think? :)
> [...]
>> I just think that refactoring needs to be done instead of copying
>> pieces from (guix scripts package).
>
> AIUI doing a "good" refactoring job will imply a lot of code moving
> because It means separating the interfaces from the functionalities.
> IMO that could be left to next iterations.  However, IIUC this patch
> could be lighter by using indirections to the 'guix-package' procedure
> fornow instead of copying chunks of code.  Is that what you mean?

No, as Andy pointed you can't just use 'guix-package' procedure for
several reasons.  My only concern is to avoid the code duplication.  I'm
afraid that postponing refactoring in practice may mean the code will
remain in this state for years.

-- 
Alex