guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Adding build status to the package list table


From: Roel Janssen
Subject: Re: Adding build status to the package list table
Date: Fri, 27 Nov 2015 01:16:16 +0100
User-agent: mu4e 0.9.15; emacs 25.1.50.1

Ludovic Courtès writes:

> Roel Janssen <address@hidden> skribis:
>
>> I've attached a patch that adds status icons to the links in the
>> expanded view. It only loads when the user clicks on "expand".
>
> This is great!
>
> Minor things: I would move the patch list above the status, and remove
> the “status:” heading.

I'll update the patch.

>> We might need to add a HTTP header from the GNU server to allow
>> loading data from external sources:
>>
>>   https://en.wikipedia.org/wiki/Cross-origin_resource_sharing
>
> Indeed, because here the requests get blocked.  Could you get in touch
> with address@hidden and report back?

I've contacted them, but haven't had a response. I'll report back when I
have a response.

>> I hope my commit message is OK this way.
>
> It’s almost perfect.  ;-)  The only missing bits are the changes to
> packages.css that are not mentioned, and the added files that must be
> listed.

I'll update the patch.

Thanks,
Roel



reply via email to

[Prev in Thread] Current Thread [Next in Thread]