Re: [PATCH 1/2] gnu: Add sonic.

[Leo Famulari]

On Wed, Jan 13, 2016 at 03:10:16PM +0100, Ludovic Courtès wrote:
> Leo Famulari <address@hidden> skribis:
> 
> > * gnu/packages/audio.scm (sonic): New variable.
> 
> [...]
> 
> > +        #:phases (modify-phases %standard-phases
> > +         (delete 'configure))))
              *-------->|
> 
> There’s a problem here.  :-)

The indentation of the second line, correct?

> 
> > +    (synopsis "Speed up or slow down speech")
> > +    (description "Sonic is a simple algorithm for speeding up or slowing 
> > down
> 
> s/is a/implements a/

> 
> > +speech.  However, it's optimized for speed ups of over 2X, unlike previous
> > +algorithms for changing speech rate.  The Sonic library is a very simple 
> > ANSI C
> > +library that is designed to easily be integrated into streaming voice
> > +applications, like TTS back ends.
> 
> I would change the last sentence to:
> 
>   Sonic is a C library designed to be easily integrated into streaming
>   voice applications such as text-to-speech (TTS) back ends.
> 
> > +The primary motivation behind Sonic is to enable the blind and visually 
> > impaired
> > +to improve their productivity with open source speech engines, like espeak.
>                                 ^‑------------------------------------------^
> Replace with “with speech engines such as eSpeak.”
> 
> > +Sonic can also be used by the sighted.  For example, Sonic can improve the
> > +experience of listening to an audio book on an Android phone.")
> 
> I’d remove these two sentences.
> 
> OK with these changes.

Done.

> 
> Thanks,
> Ludo’.