Re: [PATCH] gnu/packages/linux iptables: include firewall in description

[Leo Famulari]

On Mon, Jan 25, 2016 at 07:48:25PM +0100, Ni* Gillmann wrote:
> This is a patch to include "firewall" in the description of iptables, as
> it does not turn up with a search for "firewall" which might not be so
> intuitive for GNU beginners.
> I did not want to change the complete description (yet), I am open to
> suggestions if this short addition is not accurate. The important thing
> is to include "firewall" so it will turn up without knowing "ip
> filtering" "iptables" or similar concepts.

It's a good idea.

Typically, the kernel's packet filter is described as the "firewall" and
iptables is used to configure it [0]. Can you change it to communicate
that more clearly?

Also, can you be sure to make the commit message match the GNU changelog
[1] format? You can look at Guix's git log for examples.

Thanks!

[0]
https://en.wikipedia.org/wiki/Iptables

[1] 
http://www.gnu.org/prep/standards/standards.html#Change-Logs
https://www.gnu.org/software/guix/manual/guix.html#Submitting-Patches

> 
> 
> From 0fbccf724e62eea2874428dbc115a2095718fb66 Mon Sep 17 00:00:00 2001
> From: Ni* Gillmann <address@hidden>
> Date: Mon, 25 Jan 2016 19:08:52 +0100
> Subject: [PATCH] gnu: linux.scm: iptables: include firewall in description
> 
> ---
>  gnu/packages/linux.scm | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
> index 579df02..0d86c78 100644
> --- a/gnu/packages/linux.scm
> +++ b/gnu/packages/linux.scm
> @@ -7,6 +7,7 @@
>  ;;; Copyright © 2015 Taylan Ulrich Bayırlı/Kammer <address@hidden>
>  ;;; Copyright © 2015 Efraim Flashner <address@hidden>
>  ;;; Copyright © 2016 Christopher Allan Webber <address@hidden>
> +;;; Copyright © 2016 Nils Gillmann <address@hidden>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -881,7 +882,8 @@ Linux 2.4.x and later IPv4 packet filtering ruleset.  It 
> is targeted towards
>  system administrators.  Since Network Address Translation is also configured
>  from the packet filter ruleset, iptables is used for this, too.  The iptables
>  package also includes ip6tables.  ip6tables is used for configuring the IPv6
> -packet filter.")
> +packet filter. In the broader sense it can be seen as a firewall tool for the
> +GNU System.")
>      (license license:gpl2+)))
> 
>  (define-public iproute
> --
> 2.6.3
> 
> 

> From 0fbccf724e62eea2874428dbc115a2095718fb66 Mon Sep 17 00:00:00 2001
> From: Ni* Gillmann <address@hidden>
> Date: Mon, 25 Jan 2016 19:08:52 +0100
> Subject: [PATCH] gnu: linux.scm: iptables: include firewall in description
> 
> ---
>  gnu/packages/linux.scm | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
> index 579df02..0d86c78 100644
> --- a/gnu/packages/linux.scm
> +++ b/gnu/packages/linux.scm
> @@ -7,6 +7,7 @@
>  ;;; Copyright © 2015 Taylan Ulrich Bayırlı/Kammer <address@hidden>
>  ;;; Copyright © 2015 Efraim Flashner <address@hidden>
>  ;;; Copyright © 2016 Christopher Allan Webber <address@hidden>
> +;;; Copyright © 2016 Nils Gillmann <address@hidden>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -881,7 +882,8 @@ Linux 2.4.x and later IPv4 packet filtering ruleset.  It 
> is targeted towards
>  system administrators.  Since Network Address Translation is also configured
>  from the packet filter ruleset, iptables is used for this, too.  The iptables
>  package also includes ip6tables.  ip6tables is used for configuring the IPv6
> -packet filter.")
> +packet filter. In the broader sense it can be seen as a firewall tool for the
> +GNU System.")
>      (license license:gpl2+)))
> 
>  (define-public iproute
> --
> 2.6.3

> 
> --
> ng/ni*
> vcard: http://krosos.sdf.org