Re: [PATCH v2 04/10] gnu: Add python-pytest-flakes.

[Leo Famulari]

On Sun, Apr 24, 2016 at 11:06:18PM +1000, Ben Woodcroft wrote:
> * gnu/packages/python.scm (python-pytest-flakes,
> python2-pytest-flakes): New variables.

Thanks!

> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         (add-after 'install 'post-install-check
> +           ;; 'setup.py test' does not run tests
> +           (lambda _
> +             (zero? (system* "py.test" "test_flakes.py")))))))

Does it work if you replace the check phase? Or does the check phase do
something worthwhile? Or do the tests only work after install? Can you
answer this in the code comment? ;)

> +    (native-inputs
> +     `(("python-pytest-pep8" ,python-pytest-pep8)))
> +    (propagated-inputs
> +     `(("python-pytest-cache" ,python-pytest-cache)
> +       ("python-pytest" ,python-pytest)
> +       ("python-pyflakes" ,python-pyflakes)))

I think this could get messy in practice. If, during the build of some
other package, multiple packages try to propagate pytest, we just have
to hope that whichever pytest passes the conflict resolution mechanism
works as expected.

Can you check if it still works when these are "regular" inputs?