Re: [PATCH 2/3] gnu: Add ledger.

[Alex Griffin]

On Thu, May 12, 2016, at 04:12 AM, Alex Kost wrote:
> Hello, was this package built successfully for you?  I tried it but the
> build phase failed (I'm attaching the last part of the build process [1]
> just in case).  I don't know, maybe I just don't have enough memory
> (3GB) to build it (I had such problems with cmake before).

Yes, it builds fine for me. It looks like the important line in your
build log is "c++: internal compiler error: Killed (program cc1plus)",
which could be from running out of memory. Does it still happen if you
add `#:parallel-build? #f` to the build system arguments?

> Every phase should return non-false value if it succeeded.  So since the
> returned value of 'install-file' is not specified, we add #t to the end
> of such phases.  Please add #t to all phases except the following
> (build-doc) because zero? returns #t if succeeded.

OK, done.

> Unlike configure-flags where we can use only %build-inputs, in phases,
> it is better to use a functional style using 'inputs' passed to a phase
> as argument:

Done.

> It doesn't matter but usually we put #:configure-flags before #:phases.

Done. Attached is an updated patch.

Thanks,
-- 
Alex Griffin

0002-gnu-Add-ledger.patch
Description: Text Data