[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/3] gnu: Add ledger.
From: |
Leo Famulari |
Subject: |
Re: [PATCH 2/3] gnu: Add ledger. |
Date: |
Sat, 7 May 2016 18:23:30 -0400 |
User-agent: |
Mutt/1.6.0 (2016-04-01) |
On Sat, May 07, 2016 at 02:20:16PM -0500, Alex Griffin wrote:
> Here's an updated patch which doesn't delete the ledger-mode docs. I had
> initially removed them from this package thinking they belonged in
> emacs-ledger-mode, then forgot about it before submitting. Turns out
> it's more complicated to build the docs with the emacs-build-system than
> the cmake-build-system.
Thanks for the follow-up!
> * gnu/packages/finance.scm (ledger): New variable.
It works, at least for the basic things I tried against the examples in
'tests/input'. Speaking of which, it would be nice to include an example
in the output, perhaps under 'share/doc/ledger'.
> + (source (origin
> + (method url-fetch)
> + (uri (string-append
> "https://github.com/ledger/ledger/archive/v" version
Will you make this line < 80 characters?
> + (build-system cmake-build-system)
> + (arguments
> + `(#:phases
> + (modify-phases %standard-phases
> + (add-after 'build 'build-doc
> + (lambda _ (zero? (system* "make" "doc")))))
> + #:configure-flags
> + `("-DBUILD_DOCS:BOOL=ON"
> + "-DBUILD_LIBRARY:BOOL=OFF"
What's the story with the library? Are there any programs that use it?
> + (license (list license:bsd-3
> + license:asl2.0
> + (license:non-copyleft "file://src/wcwidth.cc"
> + "See src/wcwidth.cc in the
> distribution.")))))
There are some GPL'd files in 'contrib/', 'lisp/', and 'python/res/'
The file 'tools/update_copyright_year' has an Expat license.
And, I think that unless we delete the bundled utfcpp, we are
distributing it through `guix build --source ledger`, so we should
mention its Boost license.
- [PATCH 2/3] gnu: Add ledger., Alex Griffin, 2016/05/07
- Re: [PATCH 2/3] gnu: Add ledger., Alex Griffin, 2016/05/07
- Re: [PATCH 2/3] gnu: Add ledger.,
Leo Famulari <=
- Re: [PATCH 2/3] gnu: Add ledger., Alex Griffin, 2016/05/07
- Re: [PATCH 2/3] gnu: Add ledger., Leo Famulari, 2016/05/08
- Re: [PATCH 2/3] gnu: Add ledger., Ludovic Courtès, 2016/05/09
- Re: [PATCH 2/3] gnu: Add ledger., Leo Famulari, 2016/05/09
- Re: [PATCH 2/3] gnu: Add ledger., Alex Griffin, 2016/05/11
- Re: [PATCH 2/3] gnu: Add ledger., Alex Kost, 2016/05/12
- Re: [PATCH 2/3] gnu: Add ledger., Alex Griffin, 2016/05/12
- Re: [PATCH 2/3] gnu: Add ledger., Leo Famulari, 2016/05/12
- Re: [PATCH 2/3] gnu: Add ledger., Alex Kost, 2016/05/13
- Re: [PATCH 2/3] gnu: Add ledger., Alex Griffin, 2016/05/13