Re: [PATCH] Emacs Smartparens

[Alex Kost]

Catonano (2016-05-16 16:32 +0300) wrote:

> Ok this is my second attempt
>
> This time it's Smartparens

Thanks!

> I used the emacs build system this time and I payied a bit more
> attention to the propagated inputs. I'm not sure about the native
> input though

There is no need to specify emacs in native-inputs if emacs-build-system
is used.

I have the same comments as for the zenburn patch (especially about the
way you attach it; I can't really do anything when it is attached like
this), so let's deal with that patch at first and then you can update
this patch accordingly, if you don't mind.

Sorry for the inconvenience :-)

> From 2e15843c941fc470cfe20275c4343c300b9dc8de Mon Sep 17 00:00:00
> 2001
> From: humanitiesNerd <address@hidden>
> Date: Sun, 15 May 2016 20:40:14 +0200
> Subject: [PATCH] package definition for Smartparens appended to
>  gnu/packages/emacs.scm
>
> ---
>  gnu/packages/emacs.scm | 43
> +++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 43 insertions(+)
>
> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
> index 11010b2..a311635 100644
> --- a/gnu/packages/emacs.scm
> +++ b/gnu/packages/emacs.scm
> @@ -1559,3 +1559,46 @@ to recognize a name like \"RFC 1234\".  This
> package enhances ffap so
>  that it correctly finds RFCs even when a space appears before the
>  number.")
>      (license license:gpl3+)))
> +
> +
> +
> +(define-public emacs-smartparens
> +(package
> +  (name "emacs-smartparens")
> +  (version "1.7.1")
> +  (source
> +    (origin
> +      (method url-fetch)
> +      (uri (string-append
> +             "http://stable.melpa.org/packages/smartparens-";
> +             version
> +             ".tar"))
> +      (sha256
> +        (base32
> +          "04dvavsvmdf6fljv30csfkqkglvaw421irlq89v6zf93p0ak0vg6"))))
> +  (build-system emacs-build-system)
> +  (propagated-inputs `(("emacs-dash" ,emacs-dash))) ; what about
> cl-lib 0.3 ?

cl-lib is not needed as it is a part of Emacs now.  On MELPA, it is
specified as the package dependency because in the previous versions of
Emacs (< 24) there were no cl-lib library, so if a user have an old
emacs and installs a package that requires cl-lib, it should also be
installed.

> +  (native-inputs `(("emacs" ,emacs-no-x)))
> +  (home-page "https://github.com/Fuco1/smartparens";)
> +  (synopsis
> +    "Automatic insertion, wrapping and paredit-like navigation with
> user defined pairs.")

Synopsis shouldn't end with ".".  Did you check your package with "guix
lint"?  It should report about such things.

> +  (description
> +    "Smartparens is minor mode for Emacs that deals with parens
> pairs
> +and tries to be smart about it.  It started as a unification effort
> +to combine functionality of several existing packages in a single,
> +compatible and extensible way to deal with parentheses, delimiters,
> +tags and the like.  Some of these packages include autopair,
> +textmate, wrap-region, electric-pair-mode, paredit and others.  With
> +the basic features found in other packages it also brings many
> +improvements as well as completely new features

I don't think we need the text below in the description.

> +For a basic overview, see github readme at
> +https://github.com/Fuco1/smartparens
> +
> +For the complete documentation visit the documentation wiki located
> +at https://github.com/Fuco1/smartparens/wiki
> +
> +If you like this project, you can donate here:
> +https://www.paypal.com/cgi-bin/webscr?cmd=_s-xclick&hosted_button_id
> =CEYP5YVHDRX8C
> +")
> +  (license license:gpl3+)))
>
>

-- 
Alex