Re: [PATCH] Emacs Smartparens

[Catonano]

2016-05-16 16:35 GMT+02:00 Alex Kost <address@hidden>

Catonano (2016-05-16 16:32 +0300) wrote:

> Ok this is my second attempt
>
> This time it's Smartparens

Thanks!

;-)

 

I have the same comments as for the zenburn patch (especially about the
way you attach it; I can't really do anything when it is attached like
this), so let's deal with that patch at first and then you can update
this patch accordingly, if you don't mind.

Sorry for the inconvenience :-)

it's ok ;-)

Now, a few notes about Smartparens.

Smartparens uses Cask. Cask is a language specific project management tool.

Exactly the kind of thing that Guix aims at (right ?)

As far as I understand, Cask provides, among other things, some unit tests running facility

There's a target in a makefile piloting Cask to run the test. So I understand. And there's a folder filled with .el files containing tests to be run.

So, the makefile, the Cask file, Make, Cask and the tests folder are dependencies ONLY in development.

So maybe there should be 2 outputs for this project, one vanilla output and one for development.

It gets worse

There's a specific set of dependencies for every Smartparens submode (some languages have their own submode) so there should be an output for each of those

And finally there's also a .travis.yml file, an images folder with some gif files in it, an org-mode file and some files ending with .feature

All this seems an excess to me. A developer will be able to set up an environment with Make, Cask and other ad hoc dependencies and the files will be present in the package anyway, even if not used.

It's a few kilobytes anyway.

I hope this is ok

0001-gnu-Add-Smartparens.patch
Description: Text Data