[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/2] gnu: Add teensy-loader-cli.

From: Ludovic Courtès
Subject: Re: [PATCH 1/2] gnu: Add teensy-loader-cli.
Date: Wed, 01 Jun 2016 22:16:43 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)


Hartmut Goebel <address@hidden> skribis:

> * gnu/packages/flashing-tools.scm (teensy-loader-cli): New variable.


> +  ;; The repo does not tag versions nor does it use releases, but a commit
> +  ;; message says "Importing 2.1", while the sourcce still says "2.0". So pin
> +  ;; to a fixed commit.

No tags either?

> +  (let* ((commit "f289b7a2e5627")

Better use the full SHA1.

> +         ;; Mind the version substitute below when changing this
> +         (versionx (string-append "2.1-1." (string-take commit 7))))
> +  (package
> +    (name "teensy-loader-cli")
> +    (version versionx)

AFAICS, ‘versionx’ is not needed.  You can directly write:

    (name "teensy-loader-cli")
    (version (string-append …))

> +       (patches (search-patches "teensy-loader-cli-usage.patch"))))

You forgot to include the patch.  :-)

There’s a .elf file in the source:

--8<---------------cut here---------------start------------->8---
$ file rebootor/rebootor.elf 
rebootor/rebootor.elf: ELF 32-bit LSB executable, Atmel AVR 8-bit,— version 1 
(SYSV), statically linked, not stripped
--8<---------------cut here---------------end--------------->8---

… and a bunch of .hex files with no corresponding source, AFAICS.

Could you remove them in a ‘snippet’?

Other than that LGTM.

Could you send an updated patch?

Thank you!


reply via email to

[Prev in Thread] Current Thread [Next in Thread]