guix revisions (Re: [Patch] Tmux Themepack)

[ng0]

Hi,

Leo Famulari <address@hidden> writes:

> On Sun, Jun 12, 2016 at 04:01:41PM -0400, Matthew Jordan wrote:
>> Good Day,
>> 
>> The package has been updated inline with suggested changes.
>
> Thanks! Can you test the attached revision on your patch? Here are the
> changes:
>
>> +(define-public tmux-themepack
>> +  (let ((commit "03a372866f7677f7fe63bcee140b48b9fd372c48"))
>> +    (package
>> +      (name "tmux-themepack")
>> +      (version (string-append "1.0.0." (string-take commit 7))) ;; No 
>> version tags
>
> I think we need to improve 7.6.3 Version Numbers in the manual. *Nobody*
> gets it right the first time :)
>
> With no upstream revision, we use 0.0.0 as the version (this should be
> documented). We also include a Guix package revision number, which seems
> to begin at 1. It ends up looking like this:

A side question: We do guix revisions of packages? I know we had
a discussion on this in the past which included the string-take
commit 7 or 8, but even with using grep in the gnu/packages dir
it's not obvious as egrep -nr 'revision "1"'
for example just gives 5 results.
So the documentation needs to be improved, I agree.

-- 
♥Ⓐ  ng0
For non-prism friendly talk find me on http://www.psyced.org
SecuShare – http://secushare.org