Re: [PATCH 1/5] gnu: gtk+: Add "bin" output.

[宋文武]

Eric Bavier <address@hidden> writes:

> On Sat, 13 Aug 2016 22:21:53 -0400
> Leo Famulari <address@hidden> wrote:
>
>> On Sat, Aug 06, 2016 at 06:46:12PM +0800, 宋文武 wrote:
>> > * gnu/packages/gtk.scm (gtk+)[outputs]: New field.
>> > ---
>> >  gnu/packages/gtk.scm | 1 +
>> >  1 file changed, 1 insertion(+)
>> > 
>> > diff --git a/gnu/packages/gtk.scm b/gnu/packages/gtk.scm
>> > index 21365b9..5c42053 100644
>> > --- a/gnu/packages/gtk.scm
>> > +++ b/gnu/packages/gtk.scm
>> > @@ -624,6 +624,7 @@ application suites.")
>> >               (base32
>> >                "157nh9gg0p2avw765hrnkvr8lsh2w811397yxgjv6q5j4fzz6d1q"))
>> >              (patches (search-patches 
>> > "gtk3-respect-GUIX_GTK3_PATH.patch"))))
>> > +   (outputs '("out" "bin" "doc"))
>> >     (propagated-inputs
>> >      `(("at-spi2-atk" ,at-spi2-atk)
>> >        ("atk" ,atk)  
>> 
>> What effect does this have?
>> 
>> Does Guix know to put something into the 'bin' output?
>
> Yes, the gnu-build-system will automatically pass '--bindir' to
> 'configure' if a "bin" output is present.

Yes, this will put 'gtk-update-icon-cache', 'gtk-encode-symbolic-svg',
'gtk3-dome', etc in the "bin" output.

>
> However, should these outputs not instead be added to the 'gtk+-2'
> package that 'gtk+' inherits from?

Yeah, but do it to 'gtk+-2' will fail with cycle references between
its "bin" and "out".  So I just leave it untouched.