[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 03/13] gnu: pinentry-qt: Fix regression.
From: |
David Craven |
Subject: |
Re: [PATCH 03/13] gnu: pinentry-qt: Fix regression. |
Date: |
Mon, 22 Aug 2016 00:37:45 +0200 |
I removed gettext and added
(arguments
`(#:configure-flags '("CXXFLAGS=-std=gnu++11")))
instead. I don't know why adding gettext as a native-input fixed the
build failure.
On Sun, Aug 21, 2016 at 10:16 PM, Mark H Weaver <address@hidden> wrote:
> David Craven <address@hidden> writes:
>
>> * gnu/packages/gnupg.scm (pinentry-qt)[native-inputs]: Add gnu-gettext.
>
> The summary line should say "Add gnu-gettext to native-inputs" instead
> of "Fix regression".
>
>> ---
>> gnu/packages/gnupg.scm | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/gnu/packages/gnupg.scm b/gnu/packages/gnupg.scm
>> index 7df96b4..fde6018 100644
>> --- a/gnu/packages/gnupg.scm
>> +++ b/gnu/packages/gnupg.scm
>> @@ -28,6 +28,7 @@
>> #:use-module (gnu packages)
>> #:use-module (gnu packages adns)
>> #:use-module (gnu packages curl)
>> + #:use-module (gnu packages gettext)
>> #:use-module (gnu packages openldap)
>> #:use-module (gnu packages perl)
>> #:use-module (gnu packages pth)
>> @@ -642,6 +643,8 @@ passphrase when @code{gpg} or @code{gpg2} is run and
>> needs it.")))
>> (package
>> (inherit pinentry-tty)
>> (name "pinentry-qt")
>> + (native-inputs
>> + `(("gettext" ,gnu-gettext)))
>
> It would be good to understand why this is needed, because it shouldn't
> be needed for a tarball release. Can you add a comment explaining the
> reason, possibly with "FIXME" in it?
>
> Thanks,
> Mark
- Re: [PATCH 08/13] gnu: synthv1: Fix regression caused by update to qt 5.7., (continued)
- [PATCH 02/13] gnu: kwidgetsaddons: Fix regression caused by update to qt 5.7., David Craven, 2016/08/21
- Re: [PATCH 02/13] gnu: kwidgetsaddons: Fix regression caused by update to qt 5.7., Mark H Weaver, 2016/08/21
- [PATCH 04/13] gnu: poppler: Update to 0.47.0., David Craven, 2016/08/21
- Re: [PATCH 04/13] gnu: poppler: Update to 0.47.0., Mark H Weaver, 2016/08/21
- Re: [PATCH 04/13] gnu: poppler: Update to 0.47.0., David Craven, 2016/08/21
- [PATCH 03/13] gnu: pinentry-qt: Fix regression., David Craven, 2016/08/21
- Re: [PATCH 03/13] gnu: pinentry-qt: Fix regression., Mark H Weaver, 2016/08/21
- Re: [PATCH 03/13] gnu: pinentry-qt: Fix regression.,
David Craven <=
- [PATCH 11/13] gnu: vlc: Fix regression caused by update to qt 5.7., David Craven, 2016/08/21
- Re: [PATCH 11/13] gnu: vlc: Fix regression caused by update to qt 5.7., Mark H Weaver, 2016/08/21
- Re: [PATCH 11/13] gnu: vlc: Fix regression caused by update to qt 5.7., David Craven, 2016/08/21
- Re: [PATCH 11/13] gnu: vlc: Fix regression caused by update to qt 5.7., Leo Famulari, 2016/08/21
- Re: [PATCH 11/13] gnu: vlc: Fix regression caused by update to qt 5.7., David Craven, 2016/08/21
- Re: [PATCH 11/13] gnu: vlc: Fix regression caused by update to qt 5.7., David Craven, 2016/08/21
- Re: [PATCH 11/13] gnu: vlc: Fix regression caused by update to qt 5.7., Mark H Weaver, 2016/08/22
- Re: [PATCH 11/13] gnu: vlc: Fix regression caused by update to qt 5.7., Leo Famulari, 2016/08/21
- [PATCH 05/13] gnu: alsa-modular-synth: Fix regression caused by update to qt 5.7., David Craven, 2016/08/21
- Re: [PATCH 05/13] gnu: alsa-modular-synth: Fix regression caused by update to qt 5.7., Mark H Weaver, 2016/08/21