Re: [PATCH] gnu: Add git-review.

[Clément Lassieur]

Clément Lassieur <address@hidden> writes:

> With the patch already pushed, I get this error:
>
> --8<---------------cut here---------------start------------->8---
> Using global/system git-review config files (/etc/git-review/git-review.conf) 
> is deprecated
> Downloading refs/changes/73/36373/1 from gerrit
> Traceback (most recent call last):
>   File 
> "/gnu/store/ss27c082a95dzra46lsv9fwg0sw6x7zg-python-git-review-1.25.0/bin/.git-review-real",
>  line 10, in <module>
>     sys.exit(main())
>   File 
> "/gnu/store/ss27c082a95dzra46lsv9fwg0sw6x7zg-python-git-review-1.25.0/lib/python3.4/site-packages/git_review/cmd.py",
>  line 1522, in main
>     _main()
>   File 
> "/gnu/store/ss27c082a95dzra46lsv9fwg0sw6x7zg-python-git-review-1.25.0/lib/python3.4/site-packages/git_review/cmd.py",
>  line 1437, in _main
>     checkout_review(local_branch, remote, remote_branch)
>   File 
> "/gnu/store/ss27c082a95dzra46lsv9fwg0sw6x7zg-python-git-review-1.25.0/lib/python3.4/site-packages/git_review/cmd.py",
>  line 1123, in checkout_review
>     branch_name, "FETCH_HEAD")
>   File 
> "/gnu/store/ss27c082a95dzra46lsv9fwg0sw6x7zg-python-git-review-1.25.0/lib/python3.4/site-packages/git_review/cmd.py",
>  line 160, in run_command_exc
>     (rc, output) = run_command_status(*argv, **env)
>   File 
> "/gnu/store/ss27c082a95dzra46lsv9fwg0sw6x7zg-python-git-review-1.25.0/lib/python3.4/site-packages/git_review/cmd.py",
>  line 144, in run_command_status
>     env=newenv)
>   File 
> "/gnu/store/m4gc2wx4q9if1vrhgclpspdil7rqsn21-python-3.4.3/lib/python3.4/subprocess.py",
>  line 859, in __init__
>     restore_signals, start_new_session)
>   File 
> "/gnu/store/m4gc2wx4q9if1vrhgclpspdil7rqsn21-python-3.4.3/lib/python3.4/subprocess.py",
>  line 1395, in _execute_child
>     restore_signals, start_new_session, preexec_fn)
> UnicodeEncodeError: 'ascii' codec can't encode character '\xe9' in position 
> 9: ordinal not in range(128)
> --8<---------------cut here---------------end--------------->8---
>
> I'm sorry I didn't test it well enough. Maybe we should revert it, since
> it's probably unusable.

I had this error on a Debian/Guix laptop (without guix environment), but
I don't have it with my GuixSD laptop.