[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] gnu: Add git-review.
From: |
Efraim Flashner |
Subject: |
Re: [PATCH] gnu: Add git-review. |
Date: |
Sat, 10 Sep 2016 22:05:38 +0300 |
User-agent: |
Mutt/1.7.0 (2016-08-17) |
On Fri, Sep 09, 2016 at 06:09:40PM +0200, Clément Lassieur wrote:
> Efraim Flashner <address@hidden> writes:
>
> > I found ssh and I found an instance of scp, so this should be better.
>
> --8<---------------cut here---------------start------------->8---
> address@hidden ~/foo [env]# git-review -d 36373
> Downloading refs/changes/73/36373/1 from gerrit
> Cannot fetch patchset contents
>
> Does specified change number belong to this project?
>
> The following command failed with exit code 128
> "/gnu/store/...-git-2.10.0/bin/git fetch gerrit refs/changes/73/36373/1"
> -----------------------
> error: cannot run ssh: No such file or directory
> fatal: unable to fork
> -----------------------
> address@hidden ~/foo [env]# /gnu/store/...-git-2.10.0/bin/git remote -v
>
> gerrit ssh://bar (fetch)
> gerrit ssh://bar (push)
> --8<---------------cut here---------------end--------------->8---
>
> It looks like ssh isn't hardcoded within git either. Is it worth doing
> this for git-review then?
This looks like you are using ssh for talking to the remote server, in
which case it would exist outside of git-review. Or did I misunderstand
it?
It does seem that wrapping the program would be easier than trying to
fing regexes that work to patching only certain instances of other
programs.
--
Efraim Flashner <address@hidden> אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
signature.asc
Description: PGP signature
- [PATCH] gnu: Add python-git-review., (continued)
- Re: [PATCH] gnu: Add git-review., Ben Woodcroft, 2016/09/08
- Re: [PATCH] gnu: Add git-review., Efraim Flashner, 2016/09/08
- Re: [PATCH] gnu: Add git-review., Clément Lassieur, 2016/09/09
- Re: [PATCH] gnu: Add git-review., Efraim Flashner, 2016/09/09
- Re: [PATCH] gnu: Add git-review., Clément Lassieur, 2016/09/09
- Re: [PATCH] gnu: Add git-review.,
Efraim Flashner <=
- [PATCH] gnu: python-git-review: Wrap it so 'git', 'ssh' and 'scp' are found., Clément Lassieur, 2016/09/10
- Re: [PATCH] gnu: python-git-review: Wrap it so 'git', 'ssh' and 'scp' are found., Efraim Flashner, 2016/09/11
- Re: [PATCH] gnu: Add git-review., Clément Lassieur, 2016/09/10
- Re: [PATCH] gnu: Add git-review., Alex Kost, 2016/09/09