Re: [PATCH 2/3] gnu: Add newlib-arm-none-eabi.

[Ludovic Courtès]

Ricardo Wurmus <address@hidden> skribis:

> * gnu/packages/embedded.scm (newlib-arm-none-eabi): New variable.

[...]

> +       #:configure-flags '("--target=arm-none-eabi"
> +                           "--enable-newlib-io-long-long"
> +                           "--enable-newlib-register-fini"
> +                           "--disable-newlib-supplied-syscalls"
> +                           "--disable-nls")

Maybe a short comment to explain.  :-)

> +       #:phases
> +       (modify-phases %standard-phases
> +         (add-after 'unpack 'fix-shell-shebangs
> +           (lambda _
> +             (setenv "SHELL" (which "sh"))
> +             (setenv "CONFIG_SHELL" (which "sh"))
> +             (substitute* '("libgloss/arm/configure"
> +                            "libgloss/arm/cpu-init/Makefile.in"
> +                            "libgloss/arm/Makefile.in"
> +                            "libgloss/libnosys/Makefile.in"
> +                            "libgloss/Makefile.in")
> +               (("/bin/sh") (which "sh")))

Are they not taken care of by the ‘patch-shebangs’ phase?

Otherwise LGTM, thanks!

Ludo’.