Re: First patch & hello

[L p R n d n]

Ricardo Wurmus <address@hidden> writes:

> Hi,
>
> thank you for your contribution!
>
> > 1 . I put the package under fontutils.scm but maybe there's a better
> > place for a font viewer?
>
> This seems fine to me.
>
> > 2. I found there is a glib-or-gtk-build-system, I hesitated to use as
> > Im̀
> > not sure what its purpose. Can someone clarify its use?
>
> The glib-or-gtk-build-system is an extension of the gnu-build-system
> that is useful for GNOME packages and other packages that require a
> little more setup after installation.  Here’s what the comments in
> “guix/build-system/glib-or-gtk.scm” say:
>
> ;; This build system is an extension of the 'gnu-build-system'.  It
> ;; accomodates the needs of applications making use of glib or gtk+ 
> (with "or"
> ;; to be interpreted in the mathematical sense).  This is achieved by 
> adding
> ;; two phases run after the 'install' phase:
> ;;
> ;; 'glib-or-gtk-wrap' phase:
> ;;
> ;; a) This phase looks for GSettings schemas, GIO modules and theming 
> data.
> ;; If any of these is found in any input package, then all programs in
> ;; "out/bin" are wrapped in scripts defining the nedessary environment
> ;; variables.
> ;;
> ;; b) Looks for the existence of "libdir/gtk-3.0" directories in all 
> input
> ;; packages.  If any is found, then the environment variable "GTK_PATH" 
> is
> ;; suitably set and added to the wrappers.  The variable "GTK_PATH" has 
> been
> ;; preferred over "GTK_EXE_PREFIX" because the latter can only point to 
> a
> ;; single directory, while we may need to point to several ones.
> ;;
> ;; 'glib-or-gtk-compile-schemas' phase:
> ;;
> ;; Looks for the presence of "out/share/glib-2.0/schemas".  If that 
> directory
> ;; exists and does not include a file named "gschemas.compiled", then
> ;; "glib-compile-schemas" is run in that directory.
>
>
> > 3. I tried to get a clean patch but it needed some manual work. What
> > your workflow to produce patches? (I use emacs)
>
> Usually you would make a local git commit and then run
>
>     git format-patch -1
>
> to generate a patch file from that commit.  You could also directly 
> send
> it to the mailing list with “git send-email”.
>
> What follows are some comments about the patch.  I’m trying to be extra
> thorough; please don’t let this discourage you.  Some of my comments
> will just be matters of opinion :)

Thanks! It was exactly what I was looking for!

> > Subject: [PATCH] gnu: Add font-manager.
> >
> > ---
>
> It seems that the commit message is missing here.  In this case the
> complete commit message would be:
>
> gnu: Add font-manager.
>
> * gnu/packages/fontutils.scm (font-manager): New variable.

Do you know why it wasn't added? I used magit format-patch.

> Please remove the last sentence.  Please also reindent the description
> string (there should be no indentation for following lines).  Also
> please use two spaces after sentences.  “guix lint” will remind you of
> these things

Is there a way to specify a custom location for "guix lint"? A little
bit like the "-L" option from "guix build" for example?
I suppose the right way to invoke 'guix lint' should be to use 
"./pre-inst-env" in a local
guix repository, but I didn't find where I was supposed to find it. :/

> Could you please send an updated patch to address@hidden

I will soon. I just tested to build the package with "rounds=2" and it
seems the package isn't deterministic. Is it acceptable or a total
no-go?

Thanks again,

Lprndn