Re: 01/01: gnu: Add rclone.

[Mark H Weaver]

Hi Nicolas,

address@hidden writes:

> ngz pushed a commit to branch master
> in repository guix.
>
> commit 8b5e2e94afdef6430583c3a0ef02fe2d7fcc16d1
> Author: Nicolas Goaziou <address@hidden>
> Date:   Sun Nov 25 01:14:28 2018 +0100
>
>     gnu: Add rclone.
>     
>     * gnu/packages/sync.scm (rclone): New variable.

Did you test this?

There's a syntax error in the code, such that it not only fails to
build, but it fails even to produce a _derivation_ describing the build.
Unfortunately, this kind of error in any package causes problems for our
build farm, which currently assumes that this kind of error will not
occur.  Such errors not only cause the individual build to fail, but
moreover for the entire process that generates a new CI "evaluation" to
fail, which effectively prevents subsequent package updates on that
branch from being built until the problem is corrected.

I reverted this commit.

Please be careful when pushing to master.

     Thanks,
       Mark


> diff --git a/gnu/packages/sync.scm b/gnu/packages/sync.scm
> index e0b0af3..22262db 100644
> --- a/gnu/packages/sync.scm
> +++ b/gnu/packages/sync.scm
> @@ -3,6 +3,7 @@
>  ;;; Copyright © 2017 Ricardo Wurmus <address@hidden>
>  ;;; Copyright © 2018 Tobias Geerinckx-Rice <address@hidden>
>  ;;; Copyright © 2018 Ludovic Courtès <address@hidden>
> +;;; Copyright © 2018 Nicolas Goaziou <address@hidden>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -22,6 +23,7 @@
>  (define-module (gnu packages sync)
>    #:use-module ((guix licenses) #:prefix license:)
>    #:use-module (guix build-system cmake)
> +  #:use-module (guix build-system go)
>    #:use-module (guix build-system meson)
>    #:use-module (guix download)
>    #:use-module (guix git-download)
> @@ -243,3 +245,45 @@ over the Internet in an HTTP and CDN friendly way;
>  @item An efficient backup system.
>  @end itemize\n")
>      (license license:lgpl2.1+)))
> +
> +(define-public rclone
> +  (package
> +    (name "rclone")
> +    (version "1.45")
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://github.com/ncw/rclone.git";)
> +                    (commit (string-append "v" version))))
> +              (file-name (git-file-name name version))
> +              (sha256
> +               (base32
> +                "06xg0ibv9pnrnmabh1kblvxx1pk8h5rmkr9mjbymv497sx3zgz26"))))
> +    (build-system go-build-system)
> +    (arguments
> +     '(#:import-path "github.com/ncw/rclone"
> +       #:install-source? #f

There is a missing "#:phases" keyword here before (modify-phases ...).

> +       (modify-phases %standard-phases
> +         ;; Fix failure during "check" phase: "/homeless-shelter: permission
> +         ;; denied".
> +         (add-after 'unpack 'set-home-directory
> +           (lambda _ (setenv "HOME" "/tmp") #t)))))
> +    (synopsis "@code{rsync} for cloud storage")
> +    (description "@code{Rclone} is a command line program to sync files and
> +directories to and from different cloud storage providers.
> +
> +Features include:
> address@hidden
> address@hidden MD5/SHA1 hashes checked at all times for file integrity
> address@hidden Timestamps preserved on files
> address@hidden Partial syncs supported on a whole file basis
> address@hidden Copy mode to just copy new/changed files
> address@hidden Sync (one way) mode to make a directory identical
> address@hidden Check mode to check for file hash equality
> address@hidden Can sync to and from network, e.g., two different cloud 
> accounts
> address@hidden Optional encryption (Crypt)
> address@hidden Optional cache (Cache)
> address@hidden Optional FUSE mount (rclone mount)
> address@hidden itemize")
> +    (home-page "https://rclone.org/";)
> +    (license license:expat)))