Re: 01/01: gnu: uncrustify: Update to 0.68.1.

[Mark H Weaver]

Hi Pierre,

address@hidden writes:

> ambrevar pushed a commit to branch master
> in repository guix.
>
> commit 34843fe9238a041616f063038557d85cd8a30165
> Author: Pierre Neidhardt <address@hidden>
> Date:   Sun Nov 25 14:41:16 2018 +0100
>
>     gnu: uncrustify: Update to 0.68.1.
>     
>     * gnu/packages/code.scm (uncrustify): Update to 0.68.1.

Hydra failed to download the updated source for this, due to a SHA256
hash mismatch on the source ZIP file.  I can reproduce the same failure
on my laptop:

--8<---------------cut here---------------start------------->8---
address@hidden ~$ guix build -S uncrustify
The following derivation will be built:
   /gnu/store/a4sj7y50fwahga5zw33rn22yl1vi5y1w-uncrustify-0.68.1.zip.drv
building 
/gnu/store/a4sj7y50fwahga5zw33rn22yl1vi5y1w-uncrustify-0.68.1.zip.drv...

Starting download of 
/gnu/store/6lpmknzjk6rwp5xq3pk0b5akd4h3b1jm-uncrustify-0.68.1.zip
>From https://github.com/uncrustify/uncrustify/archive/uncrustify-0.68.1.zip...
following redirection to 
`https://codeload.github.com/uncrustify/uncrustify/zip/uncrustify-0.68.1'...
downloading from 
https://github.com/uncrustify/uncrustify/archive/uncrustify-0.68.1.zip...
 uncrustify-0.68.1.zip                                                          
                                          1.0MiB/s 00:02 | 2.3MiB transferred
sha256 hash mismatch for 
/gnu/store/6lpmknzjk6rwp5xq3pk0b5akd4h3b1jm-uncrustify-0.68.1.zip:
  expected hash: 1jb3hmm11m2mgnypapak2lgyyvspnmx9bxd9dxis5swaja2ddxlg
  actual hash:   0yamvqhflvzpvvqwc2qilqdsa3hcbmnb6pf9wzggphhywviksc7w
hash mismatch for store item 
'/gnu/store/6lpmknzjk6rwp5xq3pk0b5akd4h3b1jm-uncrustify-0.68.1.zip'
build of /gnu/store/a4sj7y50fwahga5zw33rn22yl1vi5y1w-uncrustify-0.68.1.zip.drv 
failed
View build log at 
'/var/log/guix/drvs/a4/sj7y50fwahga5zw33rn22yl1vi5y1w-uncrustify-0.68.1.zip.drv.bz2'.
guix build: error: build failed: build of 
`/gnu/store/a4sj7y50fwahga5zw33rn22yl1vi5y1w-uncrustify-0.68.1.zip.drv' failed
--8<---------------cut here---------------end--------------->8---

Could you take a look?  If upstream modified the tarball in place, could
you show us a 'diff' between the old and new versions?

     Thanks!
       Mark


> ---
>  gnu/packages/code.scm | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/gnu/packages/code.scm b/gnu/packages/code.scm
> index 7250325..1e863b0 100644
> --- a/gnu/packages/code.scm
> +++ b/gnu/packages/code.scm
> @@ -540,7 +540,7 @@ independent targets.")
>  (define-public uncrustify
>    (package
>      (name "uncrustify")
> -    (version "0.67")
> +    (version "0.68.1")
>      (source (origin
>                (method url-fetch)
>                (uri (string-append
> @@ -548,10 +548,11 @@ independent targets.")
>                      "uncrustify-" version ".zip"))
>                (sha256
>                 (base32
> -                "0n13kq0nsm35fxhdp0f275n4x0w88hdv3bdjy0hgvv42x0dx5zyp"))))
> +                "1jb3hmm11m2mgnypapak2lgyyvspnmx9bxd9dxis5swaja2ddxlg"))))
>      (build-system cmake-build-system)
>      (native-inputs
> -     `(("unzip" ,unzip)))
> +     `(("unzip" ,unzip)
> +       ("python" ,python-wrapper)))
>      (arguments
>       `(#:phases
>         (modify-phases %standard-phases