bug#26934: [PATCH 1/3] gnu: video: add libzen

[Ludovic Courtès]

Hello Ethan,

Thanks for the patch set.  Overall the patches look good to me modulo
minor issues that I’ll comment on:

"Ethan R. Jones" <address@hidden> skribis:

> ---
>  gnu/packages/video.scm | 42 ++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 42 insertions(+)

Could you provide ChangeLog-style commit logs?  See ‘git log’ for
examples and <https://gnu.org/s/guix/manual/html_node/Submitting-Patches.html>.

> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "https://mediaarea.net/download/source/";
> +                                  name
> +                                  "/"
> +                                  version
> +                                  "/"
> +                                  name
> +                                  "_"
> +                                  version
> +                                  ".tar.bz2"))

Could you squeeze that on one or two lines?

> +    (native-inputs
> +     `(("autoconf" ,autoconf)
> +       ("automake" ,automake)
> +       ("libtool" ,libtool)))

[...]

> +         (add-before 'configure 'autogen
> +           (lambda _
> +             (zero? (system* "./autogen.sh")))))))

Please double-check that this is needed.  Usually, but not always,
projects that use Autoconf & co. provide self-contained tarballs such
that one doesn’t need to run ./autogen.sh.

> +    (home-page "https://mediaarea.net/en/MediaInfo";)
> +    (synopsis "Library for libmediainfo")
> +    (description "Shared library for libmediainfo and mediainfo.")

Could you improve the synopsis and description according to the
guidelines at
<https://gnu.org/s/guix/manual/html_node/Synopses-and-Descriptions.html>?

Please take a look at
<https://gnu.org/s/guix/manual/html_node/Submitting-Patches.html> if you
haven’t already.

Could you send updated patches?

Thanks in advance!

Ludo’.