[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#26934: Re: bug#26934: [PATCH 1/3] gnu: video: add libzen
From: |
Ethan R. Jones |
Subject: |
bug#26934: Re: bug#26934: [PATCH 1/3] gnu: video: add libzen |
Date: |
Wed, 17 May 2017 19:47:47 -0400 |
<#secure method=pgp mode=sign>
Thanks for the response.
>> ---
>> gnu/packages/video.scm | 42 ++++++++++++++++++++++++++++++++++++++++++
>> 1 file changed, 42 insertions(+)
>Could you provide ChangeLog-style commit logs? See ‘git log’ for
>examples and <https://gnu.org/s/guix/manual/html_node/Submitting-Patches.html>.
So I should independently `git add --patch` each addition, then do a multi-line
`git commit` like so:
gnu: foo: Update to 1.0.
* gnu/packages/foo.scm (foo): Update to 1.0
* gnu/packages/foo.scm (libbar): New shared library.
>Could you squeeze that on one or two lines?
Is there a style on when to squeeze and when to not?
>Please double-check that this is needed.
Yup, all packages lack a proper configure script.
>Could you improve the synopsis and description
Do you have any ideas of what to add? I wasn't sure where to start
myself
Thanks!
dpg