guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#26966: [PATCH 06/22] gnu: Add ecj-javac-wrapper.


From: Ludovic Courtès
Subject: bug#26966: [PATCH 06/22] gnu: Add ecj-javac-wrapper.
Date: Mon, 22 May 2017 10:55:06 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux)

Hi!

Roel Janssen <address@hidden> skribis:

>> +           (with-output-to-file target
>> +             (lambda _
>> +               (format #t "#!~a --no-auto-compile\n!#\n" guile)
>> +               (map write
>> +                    `((use-modules (ice-9 match)
>> +                                   (ice-9 receive)
>> +                                   (ice-9 hash-table)
>> +                                   (srfi srfi-1)
>> +                                   (srfi srfi-26))
>> +                      (define defaults
>> +                        '(("-bootclasspath" ,bootcp)
>> +                          ("-source" "1.5")
>> +                          ("-target" "1.5")
>> +                          ("-cp"     ".")))

Minor nitpick: I would rather write this as

  (write `(begin
            (use-modules …)
            (define …)
            …)
          port)

because (1) ‘map’ returns a list of values, so ‘for-each’ would be more
appropriate, and (2) I think sexps should be considered as a whole
rather than as a list of sexps in general.

Ludo’.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]