bug#26966: [PATCH 06/22] gnu: Add ecj-javac-wrapper.

[Ricardo Wurmus]

Hi Ludo,

> Hi!
>
> Roel Janssen <address@hidden> skribis:
>
>>> +           (with-output-to-file target
>>> +             (lambda _
>>> +               (format #t "#!~a --no-auto-compile\n!#\n" guile)
>>> +               (map write
>>> +                    `((use-modules (ice-9 match)
>>> +                                   (ice-9 receive)
>>> +                                   (ice-9 hash-table)
>>> +                                   (srfi srfi-1)
>>> +                                   (srfi srfi-26))
>>> +                      (define defaults
>>> +                        '(("-bootclasspath" ,bootcp)
>>> +                          ("-source" "1.5")
>>> +                          ("-target" "1.5")
>>> +                          ("-cp"     ".")))
>
> Minor nitpick: I would rather write this as
>
>   (write `(begin
>             (use-modules …)
>             (define …)
>             …)
>           port)
>
> because (1) ‘map’ returns a list of values, so ‘for-each’ would be more
> appropriate, and (2) I think sexps should be considered as a whole
> rather than as a list of sexps in general.

Yes, I totally forgot about “begin”!  That’s much nicer indeed!

--
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net