[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#27412] [PATCH] gnu: rustc: Enable tests.
From: |
Marius Bakke |
Subject: |
[bug#27412] [PATCH] gnu: rustc: Enable tests. |
Date: |
Sun, 18 Jun 2017 18:17:48 +0200 |
User-agent: |
Notmuch/0.24.2 (https://notmuchmail.org) Emacs/25.2.1 (x86_64-unknown-linux-gnu) |
Danny Milosavljevic <address@hidden> writes:
> * gnu/packages/rust.scm (rustc)[source]: Remove bundled llvm.
> [native-inputs]: Add bison, flex, procps.
> [inputs]: Update llvm to llvm-3.9.1.
> [arguments]: Patch and enable tests.
Great!
[...]
> @@ -254,7 +262,18 @@ rustc-bootstrap and cargo-bootstrap packages.")
> (substitute* "src/tools/tidy/src/main.rs"
> (("^.*cargo.*::check.*$") ""))
> (substitute* "src/libstd/process.rs"
> - (("\"/bin/sh\"") (string-append "\"" bash "/bin/sh\"")))
> + ;; The newline is intentional.
> + ;; There's a line length "tidy" check in Rust which would
> + ;; fail otherwise.
> + (("\"/bin/sh\"") (string-append "
> +\"" bash "/bin/sh\"")))
Can you use '\n' instead?
> + (substitute* "src/libstd/sys/unix/process/process_common.rs"
> + (("fn test_process_mask") "#[cfg_attr(target_os =
> \"linux\", ignore)]
> +fn test_process_mask"))
I'm guessing this is disabled due to some build container oddity?
> + (substitute* "src/vendor/libc/src/lib.rs"
> + (("TODO") "TXDO"))
A comment about this would be nice.
> + ;; Our ld-wrapper cannot process non-UTF8 bytes in
> LIBRARY_PATH.
> + (delete-file-recursively
> "src/test/run-make/linker-output-non-utf8")
This is temporary, right? Maybe add the guix-devel URL?
LGTM!
signature.asc
Description: PGP signature