guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#30497] [PATCH] services: slim: Make the logged-in session show up i


From: Marius Bakke
Subject: [bug#30497] [PATCH] services: slim: Make the logged-in session show up in "w".
Date: Sat, 17 Feb 2018 16:36:28 +0100
User-agent: Notmuch/0.26 (https://notmuchmail.org) Emacs/25.3.1 (x86_64-pc-linux-gnu)

Danny Milosavljevic <address@hidden> writes:

> * gnu/services/xorg.scm (slim-shepherd-service): Make the logged-in session
> show up in "w".

Nit-pick: Instead of reusing the commit title here, it would be better
to mention what is being done, e.g. "Use SESSREG to register X11
session".

[...]

> diff --git a/gnu/services/xorg.scm b/gnu/services/xorg.scm
> index 50af2408b..b73dbe0d7 100644
> --- a/gnu/services/xorg.scm
> +++ b/gnu/services/xorg.scm
> @@ -467,6 +467,8 @@ authfile /var/run/slim.auth
>  login_cmd  exec " xinitrc " %session
>  sessiondir /run/current-system/profile/share/xsessions
>  session_msg session (F1 to change):
> +sessionstart_cmd " sessreg "/bin/sessreg -a -l $DISPLAY %user
> +sessionstop_cmd " sessreg "/bin/sessreg -d -l $DISPLAY %user

I'm surprised that this works.  I would have expected sessreg to be
unbound in this context, and that it would have to be added to the
<slim-configuration> record similar to xauth and startx.

However I suspect it may be better to add it to the record regardless,
to stay consistent and allow overriding it.  WDYT?

This is a change that affects most GuixSD users, so we better not break
anything here :-)

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]