[Halevt-dev] Halevt crushs with segmentation fault.

[Dmitry A. Ermolov]

Hi.

I added a following section in my halevt config,

---
<halevt:Device match="hal.info.category = storage">
    <halevt:Removal exec="notify-send -t 5000 'Removing:' '$hal.info.product$' 
"/>
    <halevt:Insertion exec="notify-send -t 5000 'Detected:' 
'$hal.info.product$'"/>
</halevt:Device>
---

I have an SD card and when I insert it, I get a popup message
"Detected UNKNOWN" and all seems to be OK (except the fact, that my card
has no meaningful info).

When I remove the card, halevt crushs with segmentation fault.

It seems, that patch in attachment solves the problem.

gdb backtrace follows:

593             return property->values;
(gdb) bt
#0  halevt_property_value (key=<value optimized out>, udi=<value optimized 
out>, device=<value optimized out>) at hal_interface.c:593
#1  0x0000000000405215 in halevt_run_command (exec=0xdcab40, udi=<value 
optimized out>, device=<value optimized out>) at hal_interface.c:814
#2  0x0000000000405da9 in halevt_device_removed (ctx=<value optimized out>, 
udi=0xebd804 "/org/freedesktop/Hal/devices/storage_serial_0x005d9349")
    at hal_interface.c:94
#3  0x00007fc49fbbbb99 in filter_func () from /usr/lib/libhal.so.1
#4  0x00007fc49f980f0e in dbus_connection_dispatch () from 
/usr/lib/libdbus-1.so.3
#5  0x00007fc49f758295 in message_queue_dispatch () from 
/usr/lib/libdbus-glib-1.so.2
#6  0x00007fc49f281dbe in g_main_context_dispatch () from 
/usr/lib/libglib-2.0.so.0
#7  0x00007fc49f285568 in g_main_context_iterate () from 
/usr/lib/libglib-2.0.so.0
#8  0x00007fc49f2859c5 in g_main_loop_run () from /usr/lib/libglib-2.0.so.0
#9  0x000000000040675f in main (argc=<value optimized out>, 
argv=0x7fff29963068) at manager.c:416
(gdb) frame 0
#0  halevt_property_value (key=<value optimized out>, udi=<value optimized 
out>, device=<value optimized out>) at hal_interface.c:593
593             return property->values;
(gdb) p property
$1 = (halevt_device_property *) 0x0

--
kind regards
Dmitry Ermolov

hal_interface.diff
Description: Text document