Re: Makefile C vs C++

[Hernán]

In the last mail I was confused about the macros that defines the compiler.
But, I finally found the makefile that sets the compiler.

Just to remember, I'm trying to include in an ANSI C project, some (OpenCV)
libraries made in C++.
When I included those libraries, the compiler threw the following error:

*ardrone_testing_tool.c:(.text+**0x1212): undefined reference to
`cvSURFParams'
ardrone_testing_tool.c:(.text+**0x126f): undefined reference to
`cvExtractSURF'*

Basically people told me to change the compiler to the g++ (if anyone think
about a better solution, please tell me). The main Makefile of the project
uses some standard variables like MAKE, which calls recursively another
makefile, in the folder VP_SDK/Build.

In that folder, the other makefile has some sections which calls again
another makefiles to configure variables and so on. Finally it calls
generic.makefile which sets the compiler and does the compilation.
The point is that now, when I changed the word gcc by g++ the compilation
didn't work (the original version which had worked with the gcc).
The error that it gives is the following:

*../../VLIB/video_codec.c: In function ‘int
video_codec_open_private(video_controller_t*, codec_type_t, int32_t)’:
../../VLIB/video_codec.c:75: error: invalid conversion from ‘void*’ to
‘video_macroblock_t*’
../../VLIB/video_codec.c: In function ‘int
video_codec_type_select(video_controller_t*, video_stream_t*)’:
../../VLIB/video_codec.c:190: error: invalid conversion from ‘uint32_t’ to
‘codec_type_t’
../../VLIB/video_codec.c:190: error:   initializing argument 2 of ‘int
video_codec_open_private(video_controller_t*, codec_type_t, int32_t)’
../../VLIB/video_codec.c: In function ‘int
video_encode_picture(video_controller_t*, const vp_api_picture_t*,
int32_t*)’:
../../VLIB/video_codec.c:198: error: invalid conversion from ‘int’ to
‘PixelFormat’
../../VLIB/video_codec.c: In function ‘int
video_decode_picture(video_controller_t*, vp_api_picture_t*,
video_stream_t*, int32_t*)’:
../../VLIB/video_codec.c:237: error: invalid conversion from ‘int’ to
‘PixelFormat’*

That is, an error previously hadn't detected by the gcc.
So, I think maybe I should differentiate in the code the treatment of .cpp
files and the other files.

Below in the post you will see some parts of the code. In the macro
INTERNAL_SOURCE_EXTENSIONS, there are defined the extensions .c .S .s .cpp.
You can see also that there are some other macros that depend on that...
For example INTERNAL_BINARIES_COMMON_TARGET_OFILES, which after is used to
do different things (and compilation of course).
Anyway, I'm thinking of doing something like duplicating some macros, to do
the compilation in two parts (on one side .c .S .s and on the other .cpp).
I don't know much about makefiles, so I would like to know what do you
think about that. Is that convenient to do? There is another better or
easier way to make it work?
Here I show you some lines of the file generic.makefile, but I could put
all the code if you think is necessary.
I will be really appreciated if you give me some help. May be for some of
you is not quite difficult to see the changes that has to be made in the
complete version of the code.

INTERNAL_SOURCE_EXTENSIONS= .c .S .s .cpp
>
> INTERNAL_MKDIR=mkdir -p
> INTERNAL_ECHO=echo
>
> # (in) GENERIC_COMMAND_PREFIX
> INTERNAL_CC:=$(GENERIC_COMMAND_PREFIX)gcc
> INTERNAL_AR:=$(GENERIC_COMMAND_PREFIX)ar
> INTERNAL_OBJCOPY:=$(GENERIC_COMMAND_PREFIX)objcopy
> INTERNAL_STRIP:=$(GENERIC_COMMAND_PREFIX)strip
>
> # (in) GENERIC_CFLAGS    # (in) GENERIC_LDFLAGS
> # (in) GENERIC_ARFLAGS     # (in) GENERIC_INCLUDES
> # (in) GENERIC_ADD_OFILES : for linking with     # (in)
> GENERIC_LIBRARY_SOURCE_DIR
> # (in) GENERIC_LIBRARY_SOURCE_FILES     # (in) GENERIC_LIBRARY_TARGET_DIR
> : for .o files
> INTERNAL_LIBRARY_SOURCE_FILES:=$(patsubst
> %,$(GENERIC_LIBRARY_SOURCE_DIR)/%,$(GENERIC_LIBRARY_SOURCE_FILES))
> INTERNAL_LIBRARY_TARGET_OFILES:=$(foreach
> ext,$(INTERNAL_SOURCE_EXTENSIONS),\
> $(patsubst
> $(GENERIC_LIBRARY_SOURCE_DIR)/%$(ext),$(GENERIC_LIBRARY_TARGET_DIR)/%.o,$(filter
> %$(ext),$(INTERNAL_LIBRARY_SOURCE_FILES))))
>
> # (in) GENERIC_BINARIES_SOURCE_DIR   # (in)
> GENERIC_BINARIES_COMMON_SOURCE_FILES   # (in)
> GENERIC_BINARIES_SOURCE_ENTRYPOINTS    # (in) GENERIC_BINARIES_TARGET_DIR :
> for .o files
>
> INTERNAL_BINARIES_COMMON_SOURCE_FILES:=$(patsubst
> %,$(GENERIC_BINARIES_SOURCE_DIR)/%,$(GENERIC_BINARIES_COMMON_SOURCE_FILES))
> INTERNAL_BINARIES_COMMON_TARGET_OFILES:=$(foreach
> ext,$(INTERNAL_SOURCE_EXTENSIONS),\
> $(patsubst
> $(GENERIC_BINARIES_SOURCE_DIR)/%$(ext),$(GENERIC_BINARIES_TARGET_DIR)/%.o,$(filter
> %$(ext),$(INTERNAL_BINARIES_COMMON_SOURCE_FILES))))
>  INTERNAL_BINARIES_TARGET_OENTRYPOINTS:=$(foreach
> ext,$(INTERNAL_SOURCE_EXTENSIONS),\
> $(patsubst %$(ext),$(GENERIC_BINARIES_TARGET_DIR)/%.o,$(filter
> %$(ext),$(GENERIC_BINARIES_SOURCE_ENTRYPOINTS))))
>

===================================

ifeq ($(USE_DLL),yes)

 $(GENERIC_COMMAND_PREFIX)dlltool -e
> $(GENERIC_TARGET_BINARIES_DIR)/$(DLL_ID)_exports.o --export-all-symbols -l
> $(@:.dll=.lib) $(INTERNAL_BINARIES_COMMON_TARGET_OFILES)

 $(INTERNAL_CC) --shared -o $@ $(INTERNAL_BINARIES_COMMON_TARGET_OFILES)
> $(GENERIC_TARGET_BINARIES_DIR)/$(DLL_ID)_exports.o $(GENERIC_ADD_OFILES)
> $(GENERIC_LIB_PATHS) $(GENERIC_LIBS) $(GENERIC_LDFLAGS) $(LDFLAGS_$(subst
> /,_,$*))

 $(RM) $(GENERIC_TARGET_BINARIES_DIR)/$(DLL_ID)_exports.o

  else
> $(INTERNAL_CC) -o $@ $(GENERIC_BINARIES_TARGET_DIR)/$*.o
> $(INTERNAL_BINARIES_COMMON_TARGET_OFILES) $(GENERIC_ADD_OFILES)
> $(GENERIC_LIB_PATHS) $(GENERIC_LIBS) $(GENERIC_LDFLAGS) $(LDFLAGS_$(subst
> /,_,$*))
>
  endif
>

===================================

# Build rules for each extension
> $(foreach ext,$(INTERNAL_SOURCE_EXTENSIONS),$(eval $(call
> BUILD_OFILE_TEMPLATE,LIBRARY,$(ext))))
> $(foreach ext,$(INTERNAL_SOURCE_EXTENSIONS),$(eval $(call
> BUILD_OFILE_TEMPLATE,BINARIES,$(ext))))
>
> ifneq ($(MAKECMDGOALS),clean)
> ifneq ($(MAKECMDGOALS),check)
>   -include $(INTERNAL_LIBRARY_DEPFILES) $(INTERNAL_BINARIES_DEPFILES)
> endif
> endif
>

Thank You all for any comments that you could give me.

Best Regards,

Hernán.


2012/9/18 Hernán <address@hidden>

> Thank you very much Greg,
> I've taken a look at that folder, and there is one Makefile, and several
> files with the format *.makefile.
> What I did, initially was to look for the word gcc, but as it seems it
> didn't work (*). After I saw in the main Makefile some sections that seems
> to invoque the compilator, but I don't know how to know what macro is.
>
> As it is shown in next paragraphs, that sections includes the calls to
> ADD_RULE_TEMPLATE and GENERIC_RULES_TEMPLATE. I think they both set the
> compiler with the macro $(1), but, how is that determined?, I suppose that
> is the first argument given to the function, but in the call sentence it
> doesn't seem to send the compiler type... at least is not in the format
> "gcc" that I expected...
>
> The section concerning ADD_RULE_TEMPLATE is the following :
>
>> define ADD_RULE_TEMPLATE
>>   ifeq ($$(USE_$(shell echo $(1) | tr "a-z" "A-Z")),yes)
>>     TO_BUILD+=build_$(1)
>>   endif
>> endef
>>
>> # Add rule for each target
>> $(foreach target,$(TARGETS),$(eval $(call ADD_RULE_TEMPLATE,$(target))))
>>
>
> After, the section concerning GENERIC_RULE_TEMPLATE is :
>
>> .PHONY: $(foreach target,$(TARGETS),build_$(target) clean_$(target))
>>
>> all $(MAKECMDGOALS): $(TO_BUILD)
>>     @if [ $(MAKECMDGOALS) ] && [ $(MAKECMDGOALS) = check ] ; then
>> $(SDK_SOURCE_DIR)/Build/cvsstatus.sh $(SDK_SOURCE_DIR)/Build END ; fi
>>
>> before_check:
>>     @if [ $(MAKECMDGOALS) ] && [ $(MAKECMDGOALS) = check ] ; then rm -rf
>> *.log ; fi
>>
>> define GENERIC_RULES_TEMPLATE
>>   ifneq ($(1),dll)
>>     build_$(1): before_check
>>     @$(MAKE) -f $(1).makefile $(MAKECMDGOALS)
>>   endif
>> endef
>>
>> build_dll: before_check
>>     @$(MAKE) -f app.makefile $(MAKECMDGOALS)
>>
>>
>> # Build rules for each target
>> $(foreach target,$(TARGETS),$(eval $(call
>> GENERIC_RULES_TEMPLATE,$(target))))
>>
>
> (*)
> I saw that in the main Makefile, there are some calls to two of those
> files *.makefile, which seems to check the variables and versions. The
> others *.makefile dont seem to be used, but in one of them I found a
> common.makefile which defines a macro called XCC,
> (XCC=$(GENERIC_COMMAND_PREFIX)gcc). Again, some macros are not defined in
> the makefile. This GENERIC_COMMAND_PREFIX is defined in some other
> sysvar.makefile, which is usually called in the main Makefile to throw
> errors and say the version of gcc. Which I think could omit. I'm mentioning
> that just in case I omit something important.
>
> If necessary I could send more information. I hope the explanation was
> clear.
>
> Thank you again for your time,
>
> Hernán
>
>
>
> 2012/9/18 Greg Chicares <address@hidden>
>
>> On 2012-09-17 19:25Z, Hernán F.B. wrote:
>> > I'm trying to include in an ANSI C project, some (OpenCV) libraries
>> made in
>> > c++.
>> > Basically people told me to change the compiler to the g++, but the
>> > makefile of this project is quite unusual for my experience in
>> makefiles,
>> > and I don't find out what macro to change. It uses some standard make
>> > variables like MAKECMDGOALS and MAKE (which calls recursively makefile).
>> > Here is the main part of the make file (without the macro's
>> declaration):
>> >
>> > .PHONY: $(TARGET) build_libs
>> >
>> > all: build_libs $(TARGET)
>> >
>> > $(TARGET):
>> >     @$(MAKE) -C $(SDK_PATH)/VP_SDK/Build $(TMP_SDK_FLAGS) $(SDK_FLAGS)
>> $(MAKECMDGOALS) USE_LINUX=yes
>>
>> As you said, this invokes 'make' recursively. The '-C' option
>> invokes 'make' in directory $(SDK_PATH)/VP_SDK/Build . Probably
>> that directory contains a submakefile that invokes the compiler.
>> Examine that submakefile to determine what changes may be needed
>> to support C++.
>>
>>
>> _______________________________________________
>> Help-make mailing list
>> address@hidden
>> https://lists.gnu.org/mailman/listinfo/help-make
>>
>
>