Re: Failure to compile Octave 3.0.2 on AIX 5.3

[John W. Eaton]

On  7-Oct-2008, David Bateman wrote:

| John W. Eaton wrote:
| > Oops, this patch does not do what I intended.
| > 
| > David, can you please take a look at this?  The source of the problem
| > seems to be the extern declarations in the SPARSE_SMSM_BOOL_OP and
| > SPARSE_MSM_CMP_OP macros in Sparse-op-defs.h.
| > 
| > I don't think these macros should be unconditionally declaring mixed
| > ops for Complex and double types.  If they include extern declarations
| > at all, they should probably be of the form
| > 
| >   extern OCTAVE_API SparseBoolMatrix F (const M1::elt_type&, const M2&);
| > 
| > but maybe it would be better to include the generated smx-X-Y.h file
| > that declares these mixed-type functions in any file that uses these
| > macros?  To do that will probably require some changes to the
| > sparse-mk-ops.awk script.  Also, I think the sparse-mk-ops.awk script
| > is not generating all the necessary functions and declarations.
| 
| 
| I was trying in this code to share code between
| SPARSE_SMS_CMP_OPS, SPARSE_SSM_CMP_OPS and SPARSE_SMSM_CMP_OPS, but 
| forgot the case of M1 or M2 to SPARSE_SMSM_CMP_OPS being boolean. I 
| suppose the easiest fix for this would just be to duplicate some of the 
| code to get rid of the externs. The mixed sparse boolean, double ops 
| aren't needed as Octave in that case promotes the boolean to a double in 
| any case before treating it.
| 
| Changeset attached.

I applied it.

Thanks,

jwe