Re: shisa API for setting password in plaintext

[Simon Josefsson]

Elrond <address@hidden> writes:

> On Wed, Mar 22, 2006 at 04:55:03PM +0100, Simon Josefsson wrote:
> [...]
>> I've created shishi_key_from_name:
>> 
>> int
>> shishi_key_from_name (Shishi * handle,
>>                    int32_t type,
>>                    const char *name,
>>                    const char *password, size_t passwordlen,
>>                    const char *parameter, Shishi_key ** outkey)
>> 
>> Which even does this step correctly.  Shisa now use this API.
>
> Cool.
>
> I reviewed shishi_key_from_name and
> a) learned a bit about the keymanagment in shishi.

Always good. ;)

> b) noticed a memleak on realm, principal, and salt in it.

Oops!  Fixed.

> c) Is it a good idea to call shishi_key_realm_set() and/or
>    shishi_key_principal_set()?

Definitely, thanks.

/Simon