Re: [Libcdio-devel] Re: [PATCH] OS/2 support

[Rocky Bernstein]

The iconv.m4 file that is used comes from the gettext version 0.17 package.
I checked and it is exactly the same as in that source distribution with no
modifications. Is it possible you are not using the latest version of
gettext?

Gettext claims to compile out of the box for OS/2. If you are using the
latest version of gettext and still think there is an error in that m4 file,
you should file a report in that package.

See the gettext's README for where to send your comments and bug reports.

In the event that the bug is acknowledged by gettext but somehow libcdio is
to release before gettext, we add soon-to-be-released m4 file form gettext.
But failing that I don't think it wise to change libcdio's copy of iconv.m4.


On Sat, Feb 14, 2009 at 6:37 AM, KO Myung-Hun <address@hidden> wrote:

> Hi/2.
>
> Rocky Bernstein wrote:
>
>> Sorry for the delay. The OS2 patches should now be in the libcdio git
>> repository.
>>
>> I had some problems applying the patch. (Patch wants the original listed
>> first, not second and it would have been helpful to attach this as a
>> separate file).
>>
>> I have no way to check whether these changes work. So please double check
>> my
>> work. (I often make mistakes ;-)
>>
>>
>>
>
> I've checked and it works fine. Thanks. ^^
>
> But I think m4/iconv.m4 should be modified.
>
> returning 1 means error, so it should be checked with '(size_t)(-1)' not
> '0'.
>
> --
> KO Myung-Hun
>
> Using Mozilla SeaMonkey 1.1.14
> Under OS/2 Warp 4 for Korean with FixPak #15
> On AMD ThunderBird 1 GHz with 512 MB RAM
>
> Korean OS/2 User Community : http://www.ecomstation.co.kr
>
>
>
> diff -buNr m4/iconv.m4.org m4/iconv.m4
> --- m4/iconv.m4.org     2009-02-14 15:29:42.000000000 +0900
> +++ m4/iconv.m4 2009-02-14 20:21:50.000000000 +0900
> @@ -83,7 +83,7 @@
>         size_t res = iconv (cd_utf8_to_88591,
>                             (char **) &inptr, &inbytesleft,
>                             &outptr, &outbytesleft);
> -        if (res == 0)
> +        if (res == (size_t)(-1))
>           return 1;
>       }
>   }
>
>