[libextractor] libextractor 0.5.18: plugintest fails: Invalid number of keywords (3 != 4)

[Vasil Dimov]

Hi,

Sorry to bug you with this, I didn't find a better place to send it.
If there is - please redirect me.

I found that in libextractor 0.5.18 the plugins test fails:
(does not fail with 0.5.17a)

$ ./src/test/.libs/plugintest
Invalid number of keywords (3 != 4)
$

I found that this is because libextractor_filename_extract() now adds
additional keyword "47 bytes" (47 bytes is the size of my
/etc/resolv.conf) to the list of returned keywords.

(gdb) bt
#0  libextractor_filename_extract (filename=0x8048962 "/etc/resolv.conf",
    date=0x282b0000 "nameserver 127.0.0.1\nsearch v5d.org hw.v5d.org\n",
    size=47, prev=0x804c320) at filenameextractor.c:71
#1  0x2807cd52 in getKeywords (extractor=0x804a1c0,
    filename=0x8048962 "/etc/resolv.conf",
    data=0x282b0000 "nameserver 127.0.0.1\nsearch v5d.org hw.v5d.org\n",
    size=47) at extractor.c:1163
#2  0x2807ced5 in EXTRACTOR_getKeywords (extractor=0x804a1c0,
    filename=0x8048962 "/etc/resolv.conf") at extractor.c:1230
#3  0x080487af in main (argc=1, argv=0xbfbfecb8) at plugintest.c:61
(gdb) ins *prev
$8 = {keyword = 0x804c330 "47 bytes", keywordType = EXTRACTOR_FILE_SIZE,
  next = 0x804c300}
(gdb) ins *prev->next
$9 = {keyword = 0x804c310 "resolv.conf", keywordType = EXTRACTOR_FILENAME,
  next = 0x0}
(gdb)

How should this failing test be fixed? Change the expected number of
keywords from 3 to 4 in src/test/plugintest.c:63?

PS I am glad so see my name in the AUTHORS file, thank you!
You can update my email address to address@hidden, I no longer work
for DataMax.

Best regards,
-- 
Vasil Dimov
address@hidden        Software Developer @ Oracle/Innobase Oy
address@hidden                Committer @ FreeBSD.org
address@hidden                    Home @ Sofia, Bulgaria

pgp9rWQhpzMg9.pgp
Description: PGP signature