Re: [Libqtlua-list] Compilation Warnings in QtLua

[Gustavo de Sá Carvalho Honorato]

Hi Alexandre,

sorry about taking to long to answer these issues. I was fixing this warnings but I think these warnings are errors in your code. 

Please, see these two snippets extracted from QtLua code:

- In /QtLua/qtluavalue.hxx:112 I think you mistyped _st(_st) instead of _st(st). Am I correct?

  Value::Value(lua_State *st, ValueType type)

    : _st(_st)

  {

    init_type_value(type);

  }

- In QtLua/qtluaref.hh:404 and QtLua/qtluaref.hh:396 I think the implementation is missing.

    /** This function is called when reference count has just increased.

@param Count new reference count.

    */

    virtual void ref_inc(int count)

    {

    }

    /** This functions is called when reference count has just decreased.

@param Count new reference count.

    */

    virtual void ref_drop(int count)

    {

    }

What do you think?

Thanks,

Gustavo

2011/2/19 Gustavo de Sá Carvalho Honorato <address@hidden>

Using built-in specs.

Target: i586-redhat-linux

Configured with: ../configure --prefix=/usr --mandir=/usr/share/man --infodir=/usr/share/info --with-bugurl=http://bugzilla.redhat.com/bugzilla --enable-bootstrap --enable-shared --enable-threads=posix --enable-checking=release --with-system-zlib --enable-__cxa_atexit --disable-libunwind-exceptions --enable-languages=c,c++,objc,obj-c++,java,fortran,ada --enable-java-awt=gtk --disable-dssi --enable-plugin --with-java-home=/usr/lib/jvm/java-1.5.0-gcj-1.5.0.0/jre --enable-libgcj-multifile --enable-java-maintainer-mode --with-ecj-jar=/usr/share/java/eclipse-ecj.jar --disable-libjava-multilib --with-ppl --with-cloog --with-tune=generic --with-arch=i586 --build=i586-redhat-linux

Thread model: posix

gcc version 4.4.1 20090725 (Red Hat 4.4.1-2) (GCC) 

On Sat, Feb 19, 2011 at 8:46 AM, Alexandre Becoulet <address@hidden> wrote:

On Saturday, February 19, 2011 12:31:13 am Gustavo de Sá Carvalho Honorato
wrote:

Hi,

> I've found this warnings in QtLua:

> They are very simple to solve, just neet to put Q_UNUSED in st and count
> variables. I could do this and submit a patch. It's ok or you prefer to
> solve this by yourself?

Please send your patch and I'll apply it.
Btw, what is you compiler version?

Thanks for reporting.

--
Alexandre