Re: HEAD: Kill two showstoppers at once

[Gary V. Vaughan]

Ralf Wildenhues wrote:
> * Gary V. Vaughan wrote on Tue, Aug 30, 2005 at 04:23:11PM CEST:
> >Back to work today, so no time to generate a proper patch, sorry.
>
> Here you go.

Thankyou :-D

> Just a slight cleanup of your suggestion.  Changes: change
> m4_fatal to m4_warn, because we want to be forward compatible,

Agreed.

> replace
> `symbols' with m4_split(m4_normalize([$1])) as was before.

Ah... yes, I was looking at libtool--gary--1.0, which seems to have a 
bit of crud from M4-2.0 in it.  Sorry.

> I didn't change m4_foreach to AC_FOREACH as in your snippet, because I
> don't know the difference in semantics.

AC_FOREACH([_x], [$1], == m4_foreach([_x], m4_split(m4_normalize([$1])),

Your change is correct for frozen HEAD though.  We can clean it up
post release...

> But there is another problem with respect to macro ordering: The
> settings set by the LT_INIT options appear too late in the configure
> script.  If I set AC_LIBTOOL_DLOPEN, everything is OK; but if I use
> LT_INIT([dlopen]), it appears after a macro which might override
> enable_dlopen.

Which macro is that?  The fix belongs there I think.

>  IOW, the part titled "# Set options" in LT_INIT appears
> much too late.

The only code between LT_INIT and the call to _LT_SET_OPTIONS, is a
bunch of AC_REQUIRE of foo_VERSION macros, and 
m4_require([_LT_PROG_LTMAIN]) which has a very short provide chain that 
doesn't appear to be responsible for that bug...

Does moving _LT_SET_OPTIONS([$1])dnl up to being the first line of
LT_INIT work?

> Is this bug description comprehensible?  (I guess a couple of m4_require
> and/or AC_REQUIRE are needed, I'm sure you'll know the correct answer
> right away.)

Maybe.  Or perhaps LT_INIT needs splitting, or _LT_SET_OPTIONS running 
in a diversion... If you tell me the macro that is getting emitted 
before the _LT_SET_OPTIONS expansion I should be able to figure it out.

Cheers,
        Gary.
--
Gary V. Vaughan      ())_.  address@hidden,gnu.org}
Research Scientist   ( '/   http://tkd.kicks-ass.net
GNU Hacker           / )=   http://www.gnu.org/software/libtool
Technical Author   `(_~)_   http://sources.redhat.com/autobook

signature.asc
Description: OpenPGP digital signature