libtool-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: HEAD: cross-compile test new testsuite


From: Ralf Wildenhues
Subject: Re: HEAD: cross-compile test new testsuite
Date: Wed, 5 Oct 2005 14:57:33 +0200
User-agent: Mutt/1.5.11

Hi Gary,

* Gary V. Vaughan wrote on Wed, Oct 05, 2005 at 02:48:36PM CEST:
> 
> I think there is a bug in this commit:
> 
> Ralf Wildenhues wrote:
> >Index: tests/testsuite.at
> >===================================================================
> >RCS file: /cvsroot/libtool/libtool/tests/testsuite.at,v
> >retrieving revision 1.22
> >diff -u -r1.22 testsuite.at
> >--- tests/testsuite.at       30 Sep 2005 16:00:23 -0000      1.22
> >+++ tests/testsuite.at       5 Oct 2005 08:57:25 -0000
*snip*
> > # LT_AT_LIBTOOLIZE([ARGS])
> > # ------------------------
> > m4_define([LT_AT_LIBTOOLIZE],
> >-[_lt_pkgdatadir="$abs_top_srcdir" "$LIBTOOLIZE" $1
> 
> Was this deliberate?  Most of my tests now fail because libtoolize
> is looking in the (not yet) installed macro tree for files to copy...
> 
> >+[$LIBTOOLIZE $1
> > ])

Yes, this was deliberate.  It should've been compensated by this part:

| Index: Makefile.am
| ===================================================================
| RCS file: /cvsroot/libtool/libtool/Makefile.am,v
| retrieving revision 1.168
| diff -u -r1.168 Makefile.am
| --- Makefile.am 30 Sep 2005 16:00:21 -0000      1.168
| +++ Makefile.am 5 Oct 2005 08:57:25 -0000
| @@ -492,6 +492,9 @@
|       FC="$(FC)" FCFLAGS="$(FCFLAGS)" \
|       GCJ="$(GCJ)" GCJFLAGS="$(GCJFLAGS)"
| 
| +BUILDCHECK_ENVIRONMENT = _lt_pkgdatadir="$(abs_top_srcdir)"
| +INSTALLCHECK_ENVIRONMENT =
| +
|  check-recursive: $(srcdir)/$(TESTSUITE)
| 
|  # Use `$(srcdir)' for the benefit of non-GNU makes: this is
| 
| @@ -520,12 +523,12 @@
|  # Hook the test suite into the check rule
|  check-local: tests/atconfig $(srcdir)/$(TESTSUITE)
|       $(CD_TESTDIR); \
| -     $(TESTS_ENVIRONMENT) $(SHELL) $$abs_srcdir/$(TESTSUITE) 
$(TESTSUITE_FLAGS)
| +     $(TESTS_ENVIRONMENT) $(BUILDCHECK_ENVIRONMENT) $(SHELL) 
$$abs_srcdir/$(TESTSUITE) $(TESTSUITE_FLAGS)
| 
|  # Run the test suite on the *installed* tree.
|  installcheck-local:
|       $(CD_TESTDIR); \
| -     $(TESTS_ENVIRONMENT) $(SHELL) $$abs_srcdir/$(TESTSUITE) 
$(TESTSUITE_FLAGS) AUTOTEST_PATH=$(exec_prefix)/bin
| +     $(TESTS_ENVIRONMENT) $(INSTALLCHECK_ENVIRONMENT) $(SHELL) 
$$abs_srcdir/$(TESTSUITE) $(TESTSUITE_FLAGS)
| +AUTOTEST_PATH=$(exec_prefix)/bin
| 
|  # We need to remove any file droppings left behind by testsuite
|  clean-local: clean-local-legacy

and indeed I can make tests fail if I change, for example, above
setting of _lt_pkgdatadir to point to a non-existing directory,
with both GNU make and `pmake'

On which system does this fail?  Which `make' implementation,
automake and autoconf version?

Cheers,
Ralf




reply via email to

[Prev in Thread] Current Thread [Next in Thread]