[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: HEAD: cross-compile test new testsuite
From: |
Ralf Wildenhues |
Subject: |
Re: HEAD: cross-compile test new testsuite |
Date: |
Wed, 5 Oct 2005 15:41:51 +0200 |
User-agent: |
Mutt/1.5.11 |
Hi Gary,
* Gary V. Vaughan wrote on Wed, Oct 05, 2005 at 03:26:33PM CEST:
> >
> >On which system does this fail? Which `make' implementation,
> >automake and autoconf version?
>
> On my darwin dev machine, GNU Make 3.80 as shipped by Apple with 10.4.2,
> automake-1.9.6 and autoconf-2.59 installed by me to /usr/local with the
> patches to support AC_CONFIG_LIBOBJ_DIR applied. Just to be sure, I ran
> the following:
> $ ./bootstrap
*snip*
> (dream about rewriting HACKING to mention that ordering a pizza is not
> enough)
> ...
> (write libtool-3.0 in perl)
> ...
> (wake up in a cold sweat)
ROTFL. The perl part is what convinced me you had to be joking. :)
> $ make check-local TESTSUITE_FLAGS='-v -d 1'
> abs_srcdir=`CDPATH="${ZSH_VERSION+.}:" && cd .. && pwd`; cd tests; \
> MAKE="make" CC="gcc" CFLAGS="-g -O2" CPP="gcc -E" CPPFLAGS=""
> LD="/usr/bin/ld" LDFLAGS="" LIBS="" LN_S="ln -s" NM="/usr/bin/nm -p"
> RANLIB="ranlib" OBJEXT="o" EXEEXT="" SHELL="/bin/sh" CONFIG_SHELL="/bin/sh"
> CXX="g++" CXXFLAGS="-g -O2" CXXCPP="g++ -E" F77="gfortran" FFLAGS="-g -O2"
> FC="gfortran" FCFLAGS="-g -O2" GCJ="gcj" GCJFLAGS="-g -O2"
> _lt_pkgdatadir="" /bin/sh $abs_srcdir/tests/testsuite -v -d 1
> :-(
>
> Ahah! $(abs_top_srcdir) is not defined by autoconf-2.59 :->
OK to apply the following fix?
Cheers, and sorry for the incomplete testing :-/
Ralf
* Makefile.am: Simplify. Do not use abs_top_srcdir.
Reported by Gary V. Vaughan <address@hidden>.
Index: Makefile.am
===================================================================
RCS file: /cvsroot/libtool/libtool/Makefile.am,v
retrieving revision 1.169
diff -u -r1.169 Makefile.am
--- Makefile.am 5 Oct 2005 08:58:18 -0000 1.169
+++ Makefile.am 5 Oct 2005 13:40:39 -0000
@@ -492,9 +492,6 @@
FC="$(FC)" FCFLAGS="$(FCFLAGS)" \
GCJ="$(GCJ)" GCJFLAGS="$(GCJFLAGS)"
-BUILDCHECK_ENVIRONMENT = _lt_pkgdatadir="$(abs_top_srcdir)"
-INSTALLCHECK_ENVIRONMENT =
-
check-recursive: $(srcdir)/$(TESTSUITE)
# Use `$(srcdir)' for the benefit of non-GNU makes: this is
@@ -523,12 +520,12 @@
# Hook the test suite into the check rule
check-local: tests/atconfig $(srcdir)/$(TESTSUITE)
$(CD_TESTDIR); \
- $(TESTS_ENVIRONMENT) $(BUILDCHECK_ENVIRONMENT) $(SHELL)
$$abs_srcdir/$(TESTSUITE) $(TESTSUITE_FLAGS)
+ $(TESTS_ENVIRONMENT) _lt_pkgdatadir="$$abs_srcdir" $(SHELL)
$$abs_srcdir/$(TESTSUITE) $(TESTSUITE_FLAGS)
# Run the test suite on the *installed* tree.
installcheck-local:
$(CD_TESTDIR); \
- $(TESTS_ENVIRONMENT) $(INSTALLCHECK_ENVIRONMENT) $(SHELL)
$$abs_srcdir/$(TESTSUITE) $(TESTSUITE_FLAGS) AUTOTEST_PATH=$(exec_prefix)/bin
+ $(TESTS_ENVIRONMENT) $(SHELL) $$abs_srcdir/$(TESTSUITE)
$(TESTSUITE_FLAGS) AUTOTEST_PATH=$(exec_prefix)/bin
# We need to remove any file droppings left behind by testsuite
clean-local: clean-local-legacy
- Re: HEAD: cross-compile test new testsuite, Ralf Wildenhues, 2005/10/02
- Re: HEAD: cross-compile test new testsuite, Ralf Wildenhues, 2005/10/05
- Re: HEAD: cross-compile test new testsuite, Gary V. Vaughan, 2005/10/05
- Re: HEAD: cross-compile test new testsuite, Ralf Wildenhues, 2005/10/05
- Re: HEAD: cross-compile test new testsuite, Gary V. Vaughan, 2005/10/05
- Re: HEAD: cross-compile test new testsuite, Gary V. Vaughan, 2005/10/05
- more useful installcheck (was: HEAD: cross-compile test new testsuite), Ralf Wildenhues, 2005/10/06
- Re: more useful installcheck, Gary V. Vaughan, 2005/10/07
- Re: more useful installcheck, Ralf Wildenhues, 2005/10/07
- Re: HEAD: cross-compile test new testsuite,
Ralf Wildenhues <=
- Re: HEAD: cross-compile test new testsuite, Gary V. Vaughan, 2005/10/05
- FYI: HEAD: cross-compile test new testsuite, Ralf Wildenhues, 2005/10/05