Re: 330-gary-ltdl-vs-need-lib-prefix-unknown

[Gary V. Vaughan]

On Jun 23, 2007, at 12:57 PM, Ralf Wildenhues wrote:
> Hi Gary,

Hallo Ralf,

> * Gary V. Vaughan wrote on Sat, Jun 23, 2007 at 06:17:56PM CEST:
> > On Jun 23, 2007, at 5:27 AM, Ralf Wildenhues wrote:
> > > * Gary V. Vaughan wrote on Thu, Jun 21, 2007 at 04:06:25AM CEST:
> >
> > > I've retested now.  Things seem to work well for me, on GNU/Linux.
> > > I do have a BeOS installation on my old, dusty PC, but it will be at
> > > least a couple of weeks until I have enough time to actually try to
> > > build and test Libtool HEAD on it.
> >
> > I hope you don't mean you want the patch to bitrot for another  
> > couple of
> > weeks before approving :-(
>
> No, that's not what I meant to say.  But very likely I may not have
> time until then anyway, being away for some days after Monday, and
> then some more.  Maybe someone else can review them if I don't get
> to it before.

Okay.  Well, it can't be helped.

I suspect there will come a point where I have a patch queue that I  
think
constitutes 2.1b, and several of the elements will be stalled on review.
I certainly appreciate your efforts in review, and don't want to demean
them in any way, it is just unfortunate that you are the only person
who takes the time to do thorough reviews, and are in danger of becoming
the bottleneck.  We instituted the 72 hour rule to prevent this sort of
thing.  May I humbly suggest that we go back to our older (faster) way
of working where 72 hours after submission, it's okay to commit unless
someone raises a concern... at which point we can resort to the  
meticulous
review process.  WDYT?

> > > > +#ifdef LT_DEBUG_LOADERS
> > > > +  fprintf (stderr, "tryall_dlopen (%s, %s)\n", filename,
> > > > +          vtable ? vtable->name : "(ALL)");
> > >
> > > Need to test filename == NULL and output "(null)" in that case.
> >
> > Since it's just debug code, and fprintf usually handles that
> > automatically it didn't seem worth the trouble.
>
> You can use
>
> static const char *
> non_null (const char *s)
> {
>   if (s) return s;
>   else   return "(null)";
> }

I'd rather use the ternary operator than start to introduce functions
in a different block of #ifdef statements.

> to avoid repetition.  But I think even debug code should be clean of
> NULL pointer dereferences.

Okay.

> > > Inconsistent TAB vs. space indentation (yeah I'm nitpicky ;-).
>
> > Maybe we should write a sed script that cleans this up?  I'll do it
> > by hand this time.
>
> Oh, I don't think it's all that important.

:-?

> > > I haven't been able to review the rest of the changes in
> > > ltdl.c:tryall_dlopen and try_dlopen yet, sorry; the other changes in
> > > your patch look good.  Judging from the number of different bits, I
> > > wonder whether they bugs they fix are covered well enough in our
> > > testsuite, though?
> >
> > Absolutely our testsuite has less than full coverage.  Should we
> > start to record a TODO list of needed tests in CVS?
>
> Feel free to.

Okay.

Cheers,
        Gary
--
  ())_.              Email me: address@hidden
  ( '/           Read my blog: http://blog.azazil.net
  / )=         ...and my book: http://sources.redhat.com/autobook
`(_~)_ Join my AGLOCO Network: http://www.agloco.com/r/BBBS7912

PGP.sig
Description: This is a digitally signed message part