libtool-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] GNU/kOpenSolaris port


From: Ralf Wildenhues
Subject: Re: [PATCH] GNU/kOpenSolaris port
Date: Mon, 29 Dec 2008 23:40:55 +0100
User-agent: Mutt/1.5.18 (2008-05-17)

Hello Robert,

thank you for the patch and the testing.

* Robert Millan wrote on Mon, Dec 22, 2008 at 03:40:34AM CET:
> 
> I ported libtool to GNU/kOpenSolaris [1].  Because the checks are
> always the same for all Glibc-based systems, and having to wait for
> libtool to propagate to every package out there is a PITA, I propose
> using a generic '*-gnu' match.

I think the patch is mostly ok, but some details matter: you are not
adjusting _LT_ENABLE_LOCK, which probably means $LD is not getting an
appropriate '-m $emul' flag set, right?  (I guess that also means our
testsuite needs some help here.)

Secondly, at a glance I don't see support for your system's canonical
name in config.guess/config.sub.  Have you already sent a patch to the
address@hidden address for that?

If you have, then what is the exact config.guess name for this system?
This matters because while matching *-gnu might be the right thing for
all systems with glibc, the ordering in the file may matter in that we
shouldn't by accident have some other case branch that matches it
earlier (this is mostly so we don't regress accidentally in the future).


Independently, does anyone remember problems with some *-gnu package
having needed some special treatment in the past, or were we just
cautious in adding things like x86_64-*kfreebsd*-gnu, k*bsd*-gnu?

Thanks,
Ralf




reply via email to

[Prev in Thread] Current Thread [Next in Thread]