Re: [PATCH] [cygwin|mingw] cwrapper cleanups.

[Ralf Wildenhues]

Hi Charles,

* Charles Wilson wrote on Wed, Jan 21, 2009 at 10:14:22PM CET:
> libltdl/config/ltmain.m4sh (func_emit_cwrapperexe_src)
> [file scope]: re-organized includes and portability
> macros. Avoid oldnames on MINGW32 and MSVC for
> setmode/stat/chmod/getcwd/putenv. Declare _putenv on
> MINGW32 when -ansi.

OK, thanks.  The only part that looks arbitrary is this one:

> Use namespaced macro LT_DEBUGWRAPPER.

It is not accompanied by any documentation change or testsuite change.
This of course isn't this patch's fault, but shows that there is some
documentation and some test missing.  It would be nice if this were
addressed in another patch.  :-)

> It's interesting that on mingw, when -std=c89, there is no declaration
> of putenv (or _putenv) in the system headers. However, with -Werror the
> compilation of the wrapper succeeds even without this patch -- but there
> is an error:
>   if (putenv (str) != EXIT_SUCCESS)
> You have to turn on -Wall (with -std=c89) to get mingw gcc to complain:
>   In function `lt_setenv':
>   warning: implicit declaration of function `putenv'
> However, in -std=c99 mode, this warning is printed /without/ -Wall.

If you want to add a round using -Wall to the cwrapper test (or add
-Wall to one of the current rounds), consider such a change preapproved.

Cheers,
Ralf