Re: [PATCH] [cygwin|mingw] cwrapper cleanups.

[Charles Wilson]

Ralf Wildenhues wrote:
> * Charles Wilson wrote on Wed, Jan 21, 2009 at 10:14:22PM CET:
>> libltdl/config/ltmain.m4sh (func_emit_cwrapperexe_src)
>> [file scope]: re-organized includes and portability
>> macros. Avoid oldnames on MINGW32 and MSVC for
>> setmode/stat/chmod/getcwd/putenv. Declare _putenv on
>> MINGW32 when -ansi.
> 
> OK, thanks. 

Pushed.

> The only part that looks arbitrary is this one:
> 
>> Use namespaced macro LT_DEBUGWRAPPER.
> 
> It is not accompanied by any documentation change or testsuite change.
> This of course isn't this patch's fault, but shows that there is some
> documentation and some test missing.  It would be nice if this were
> addressed in another patch.  :-)

Preparing a followup patch (#1).

> If you want to add a round using -Wall to the cwrapper test (or add
> -Wall to one of the current rounds), consider such a change preapproved.

Preparing a followup patch (#2).

--
Chuck