[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] improve code for sysroot --mode=finish
From: |
Ralf Wildenhues |
Subject: |
Re: [PATCH] improve code for sysroot --mode=finish |
Date: |
Mon, 16 Aug 2010 21:21:19 +0200 |
User-agent: |
Mutt/1.5.20 (2010-04-22) |
* Paolo Bonzini wrote on Sun, Aug 15, 2010 at 06:57:18PM CEST:
> Here are the improvements you suggested. I'll send a patch for
> sed_make_literal_regex soon.
>
> Ok?
Yes, with the nit addressed. Thanks!
Ralf
> * libltdl/config/ltmain.m4sh (func_mode_finish): Change sysroot_regex
> and sysroot_cmd delimiter from pipe to slash. Wrap the entire for
> loop with "if $opt_dry_run...fi" and print an explanatory message
> for the --dry-run case.
> --- a/libltdl/config/ltmain.m4sh
> +++ b/libltdl/config/ltmain.m4sh
> @@ -1419,24 +1419,27 @@ func_mode_finish ()
> done
>
> if test -n "$libs"; then
> - tmpdir=`func_mktempdir`
> if test -n "$lt_sysroot"; then
> - sysroot_regex=`$ECHO "$lt_sysroot" | $SED 's/[].[^$\\*|]/\\\\&/g'`
> - sysroot_cmd="s|\([ ']\)$sysroot_regex|\1|g;"
> + sysroot_regex=`$ECHO "$lt_sysroot" | $SED 's/[].[^$\\*/]/\\\\&/g'`
You need a \ before the / inside the bracket expression:
+ sysroot_regex=`$ECHO "$lt_sysroot" | $SED 's/[].[^$\\*\/]/\\\\&/g'`
'info Autoconf --index sed' explains why.
> + sysroot_cmd="s/\([ ']\)$sysroot_regex/\1/g;"
- Re: [PATCH v2 2/4] fix sysroot handling for deplibs of preopened libtool libs, (continued)
Re: [PATCH v2 0/3] sysroot followup patches, Charles Wilson, 2010/08/16
- Re: [PATCH v2 0/3] sysroot followup patches, Ralf Wildenhues, 2010/08/16
- Re: [PATCH v2 0/3] sysroot followup patches, Charles Wilson, 2010/08/16
- Re: [PATCH v2 0/3] sysroot followup patches, Ralf Wildenhues, 2010/08/16
- Re: [PATCH v2 0/3] sysroot followup patches, Charles Wilson, 2010/08/16
- Re: [PATCH v2 0/3] sysroot followup patches, Ralf Wildenhues, 2010/08/16
- Re: [PATCH v2 0/3] sysroot followup patches, Charles Wilson, 2010/08/16
Re: [PATCH v2 0/3] sysroot followup patches, Charles Wilson, 2010/08/21
Re: [PATCH v2 0/3] sysroot followup patches, Paolo Bonzini, 2010/08/22
Re: [PATCH v2 0/3] sysroot followup patches, Charles Wilson, 2010/08/16