[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/6] Fix partial commit support.
From: |
Gary V. Vaughan |
Subject: |
Re: [PATCH 2/6] Fix partial commit support. |
Date: |
Wed, 1 Sep 2010 09:09:42 +0700 |
Hallo Ralf,
On 1 Sep 2010, at 00:46, Ralf Wildenhues wrote:
> * Gary V. Vaughan wrote on Tue, Aug 31, 2010 at 08:43:16AM CEST:
>> * clcommit.m4sh (func_commit): Commit only staged files instead
>> of passing `-a' when no file list was given on the command line.
>
> FWIW, I've never used clcommit since we moved to git; I just use
> plain git.
Actually, I was using it as a crutch not to get to grips with git,
which is indeed very powerful... but also complex and difficult to
understand fully.
Now that I've had the opportunity to use git properly, I concur
that our commit script is obsolete... especially if we eventually
move towards generating our ChangeLog from git commit messages,
sidestepping the main point of our commit script entirely (to
keep ChangeLog and git log messages in sync).
When I next have time after the release, I'll submit a patch to
remove it.
> Come to think, why do we have this script in the Libtool tree at all?
For historical reasons.
> There is no apparent connection to the Libtool functionality. Maybe
> this, as well as announce-gen, could live in their own project?
announce-gen is referenced by cfk.mk (nee Makefile.maint) in the
release rules, which makes it useful for automating the release
process.
Maybe it makes sense to remove announce-gen and the rules that
reference it none-the-less, and free the person making each release
to type up their release announcement as they see fit.
Cheers,
--
Gary V. Vaughan (address@hidden)
PGP.sig
Description: This is a digitally signed message part
- Backport non-gnulib dependent parts of my use-gnulib topic branch, Gary V. Vaughan, 2010/08/31
- [PATCH 1/6] Add --gnulib-version and --news options to announce-gen., Gary V. Vaughan, 2010/08/31
- [PATCH 2/6] Fix partial commit support., Gary V. Vaughan, 2010/08/31
- [PATCH 3/6] Support missing detached signatures, like gnulib implementation., Gary V. Vaughan, 2010/08/31
- [PATCH 4/6] Rewrite bootstrap script for consistency with our other shell code., Gary V. Vaughan, 2010/08/31
- [PATCH 6/6] Simplify and improve safety of bootstrap process., Gary V. Vaughan, 2010/08/31
- [PATCH 5/6] Don't leak developer GREP, SED etc into distribution file., Gary V. Vaughan, 2010/08/31