[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 4/6] Rewrite bootstrap script for consistency with our other
From: |
Gary V. Vaughan |
Subject: |
Re: [PATCH 4/6] Rewrite bootstrap script for consistency with our other shell code. |
Date: |
Wed, 1 Sep 2010 09:22:32 +0700 |
On 1 Sep 2010, at 01:03, Ralf Wildenhues wrote:
> * Gary V. Vaughan wrote on Tue, Aug 31, 2010 at 08:43:18AM CEST:
>> * bootstrap: Add a proper option parsing loop, along with copies
>> of supporting functions from `libltd/m4/getopt.m4sh' and
>> `libltdl/m4/general.m4sh'.
>> Reformat header comments to work with `func_help' and
>> `func_version'.
>> (my_sed_traces): Expanded to extract all parameters from
>> configure.ac, without additional shell munging.
>
> This patch does not add new functionality to Libtool, nor does it fix
> existing bugs. It is unknown whether this patch introduces regressions,
> but experience shows that a patch of this size has a nonzero chance of
> doing so. On these grounds, I reject the patch.
>
> Specifically, I think that bootstrap needs to be only about a screenful
> long, excluding comments. We should be making it shorter, not longer.
I posted a v2 patch which hasn't made it to the archives yet which
address all of these by generating from getopts.m4sh like our other
scripts.
Cheers,
--
Gary V. Vaughan (address@hidden)
PGP.sig
Description: This is a digitally signed message part
- Re: [PATCH 1/6] Add --gnulib-version and --news options to announce-gen., (continued)
- [PATCH 2/6] Fix partial commit support., Gary V. Vaughan, 2010/08/31
- [PATCH 3/6] Support missing detached signatures, like gnulib implementation., Gary V. Vaughan, 2010/08/31
- [PATCH 4/6] Rewrite bootstrap script for consistency with our other shell code., Gary V. Vaughan, 2010/08/31
- [PATCH 6/6] Simplify and improve safety of bootstrap process., Gary V. Vaughan, 2010/08/31
- [PATCH 5/6] Don't leak developer GREP, SED etc into distribution file., Gary V. Vaughan, 2010/08/31
- Re: Backport non-gnulib dependent parts of my use-gnulib topic branch, Ralf Wildenhues, 2010/08/31