|
From: | Roumen Petrov |
Subject: | Re: [PATCH] tests: skip with-pic test when no "real" pic flag is used. |
Date: | Wed, 19 Sep 2012 22:43:26 +0300 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120910 Firefox/15.0.1 SeaMonkey/2.12.1 |
Peter Rosin wrote:
* tests/with-pic.at: Windows uses "-DDLL_EXPORT -DPIC" as the pic "flag", but never applies it to static libraries. Cater for this and skip if no "real" pic flag is in use.
I'm not sure that this test is suitable for mingw host.
No as libtool should define -DPIC and for mingw host "pic" flag is -DDLL_EXPORTSigned-off-by: Peter Rosin <address@hidden> --- tests/with-pic.at | 11 ++++++++++- 1 files changed, 10 insertions(+), 1 deletions(-) Ok to push?
Roumen
[Prev in Thread] | Current Thread | [Next in Thread] |