Re: [PATCH] tests: skip with-pic test when no "real" pic flag is used.

[Roumen Petrov]

Peter Rosin wrote:
> On 2012-09-19 21:43, Roumen Petrov wrote:
> > Peter Rosin wrote:
> > > * tests/with-pic.at: Windows uses "-DDLL_EXPORT -DPIC" as the pic
> > > "flag", but never applies it to static libraries. Cater for this
> > > and skip if no "real" pic flag is in use.
> > I'm not sure that this test is suitable for mingw host.
> >
> >
> > > Signed-off-by: Peter Rosin <address@hidden>
> > > ---
> > >    tests/with-pic.at |   11 ++++++++++-
> > >    1 files changed, 10 insertions(+), 1 deletions(-)
> > >
> > > Ok to push?
> > No as libtool should define -DPIC and for mingw host "pic" flag is -DDLL_EXPORT
> The test skips on MinGW with the patch, w/o the patch it
> fails. You are first saying that the test is not suitable
> for MinGW (implying that a skip is in order), and then you
> don't like the patch (implying that a fail is good news).
> You don't make any sense.
>
> So, what do you mean?
On woe libtool define -DDLL_EXPORT as pic flag . So the value is 
pic_flag=" -DDLL_EXPORT -DPIC"
On some "other" platform "PIC default". I don't have asses to those 
platforms and I could guess that the value is pic_flag="-DPIC", i.e. 
only wit defines.

If I understand patched code properly, skip the test if pic_flag contain 
only defines. This mean that "other" platform will be skipped too.

What about to skip test only if DLL_EXPORT is in pic_flag ?

> Cheers,
> Peter

Roumen