|
From: | Han-Wen Nienhuys |
Subject: | Re: system-count bugfix |
Date: | Sun, 14 May 2006 12:39:33 +0200 |
User-agent: | Thunderbird 1.5 (X11/20060313) |
Joe Neeman schreef:
On Sun, 14 May 2006 02:07, Han-Wen Nienhuys wrote:Joe Neeman schreef:{ Output_def *l = pscore_->layout (); - Real extent = scm_to_double (l->c_variable ("system-height")); + Real extent = robust_scm2double (l->c_variable ("system-height"), 12.0); Real padding = scm_to_double (l->c_variable ("between-system-padding")); Real space = scm_to_double (l->c_variable ("between-system-space")); bool ragged_right = to_boolean (pscore_->layout ()->c_variable ("ragged-right"));Is ok, but wouldn't it be fitting to print a warning somewher about the need to define system-height if using constrained page breaking?I thought it would be better just to provide a sane default and only involve the user when it needs to be changed. But maybe ly/paper-defaults.ly would be a better place for this?
yes, but the robust_() call is better in any case. -- Han-Wen Nienhuys - address@hidden - http://www.xs4all.nl/~hanwen LilyPond Software Design -- Code for Music Notation http://www.lilypond-design.com
[Prev in Thread] | Current Thread | [Next in Thread] |