lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: lilypond lily/context.cc lily/context-def.cc li...


From: Erik Sandberg
Subject: Re: lilypond lily/context.cc lily/context-def.cc li...
Date: Tue, 16 May 2006 18:14:40 +0200
User-agent: KMail/1.9.1

On Tuesday 16 May 2006 14:36, Han-Wen Nienhuys wrote:
> Erik Sandberg schreef:
> > +  // TODO: The above operations should be performed by a listener to the
> > following event. +  send_stream_event (this, "CreateContext",
> > +                     ly_symbol2scm ("unique"), scm_int2num (unique),
> > +                     ly_symbol2scm ("ops"), ops,
> > +                     ly_symbol2scm ("type"), cdef->get_context_name (),
> > +                     ly_symbol2scm ("id"), scm_makfrom0str (id.c_str
> > ()));
> >
> >
> > +void
> > +Context::internal_send_stream_event (SCM type, SCM props[])
> > +{
> > +  Stream_event *e = new Stream_event (this, type);
> > +  for (int i = 0; props[i]; i++)
> > +  {
> > +    assert(props[i+1]);
> > +    e->internal_set_property (props[i], props[i+1]);
> > +  }
>
> How  is this possible? I thought I asked to test "make web" before
> committing? This doubly wrong: the increment should be 2, 
Oops, sorry (I don't think it affects make web, because stream events aren't 
used yet.)

> and there is 
> no trailing NULL in the call.
notabug. see definition of send_stream_event. I added a comment.

-- 
Erik




reply via email to

[Prev in Thread] Current Thread [Next in Thread]